New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Mango test suite harness, add Windows compat #1733

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@wohali
Member

wohali commented Nov 13, 2018

Overview

Mango's test harness was a non-portable shell script. This uses the inbuilt dev/run ability to run another script once the harness is ready.

Also modified Makefile.win to add support for running more test suites, including Mango.

Testing recommendations

make mango-test should pass.

Related Issues or Pull Requests

Still 2 tests failing on Windows, see #1732

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@wohali wohali requested a review from garrensmith Nov 13, 2018

@garrensmith

Thanks @wohali this is great.

@wohali wohali merged commit b568496 into master Nov 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wohali wohali deleted the mango-harness-windows branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment