Test suite fixes for Windows #1736
Merged
Conversation
Unfortuantely, os:timestamp() on Windows only has millisecond accuracy. That means that the two Mango tests checking for a positive value of execution_time fail, since these tests appear to be running in <1ms on my test setup (a rather anemic Windows VM!) This change disables only the check for execution_time in two tests, and leaves the remainder of the execution_stats checks in place on Windows. It also introduces a convenience "make.cmd" file so you can "make check" without typing "make -f Makefile.win check" all the time.
"It's the test suite, it can't be DNS!" "It's ALWAYS DNS."
| @@ -1,5 +1,7 @@ | |||
| @ECHO OFF | |||
|
|
|||
| cd %~dp0 | |||
| call mix local.hex --force | |||
| call mix local.rebar --force | |||
wohali
Nov 13, 2018
Author
Member
This change, and the one to test/elixir/run, will be necessary to make the Elixir tests work in a CI environment - otherwise an interactive prompt is raised to first install hex, then to install rebar.
This change, and the one to test/elixir/run, will be necessary to make the Elixir tests work in a CI environment - otherwise an interactive prompt is raised to first install hex, then to install rebar.
|
@jaydoane says this all runs fine for him, so that's an informal +1. Would like a +1 from a committer before I merge this though. |
|
+1 LGTM |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Overview
os:timestamp()on Windows only has millisecond accuracy, leading to the failure of 2 mango tests. This closes #1732 by disabling theexecution_time_mscheck on Windows only, since these 2 tests seem to be completing in <1ms and failing the> 0check.This also fixes the elixir suite by using
127.0.0.1instead oflocalhost. It's ALWAYS DNS.The bump to
mix.*was recommended by @davisp in #1730. Closes #1730.Testing recommendations
Trust me on this one - or you can build your own Windows instance if you want...
Checklist