Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite fixes for Windows #1736

Merged
merged 3 commits into from Nov 13, 2018
Merged

Test suite fixes for Windows #1736

merged 3 commits into from Nov 13, 2018

Conversation

@wohali
Copy link
Member

@wohali wohali commented Nov 13, 2018

Overview

os:timestamp() on Windows only has millisecond accuracy, leading to the failure of 2 mango tests. This closes #1732 by disabling the execution_time_ms check on Windows only, since these 2 tests seem to be completing in <1ms and failing the > 0 check.

This also fixes the elixir suite by using 127.0.0.1 instead of localhost. It's ALWAYS DNS.

The bump to mix.* was recommended by @davisp in #1730. Closes #1730.

Testing recommendations

Trust me on this one - or you can build your own Windows instance if you want...

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • n/a Documentation reflects the changes;
wohali added 2 commits Nov 13, 2018
Unfortuantely, os:timestamp() on Windows only has millisecond
accuracy. That means that the two Mango tests checking for a positive
value of execution_time fail, since these tests appear to be running
in <1ms on my test setup (a rather anemic Windows VM!)

This change disables only the check for execution_time in two tests,
and leaves the remainder of the execution_stats checks in place
on Windows.

It also introduces a convenience "make.cmd" file so you can
"make check" without typing "make -f Makefile.win check" all the time.
"It's the test suite, it can't be DNS!"

"It's ALWAYS DNS."
@@ -1,5 +1,7 @@
@ECHO OFF

cd %~dp0
call mix local.hex --force
call mix local.rebar --force

This comment has been minimized.

@wohali

wohali Nov 13, 2018
Author Member

This change, and the one to test/elixir/run, will be necessary to make the Elixir tests work in a CI environment - otherwise an interactive prompt is raised to first install hex, then to install rebar.

@wohali
Copy link
Member Author

@wohali wohali commented Nov 13, 2018

@jaydoane says this all runs fine for him, so that's an informal +1. Would like a +1 from a committer before I merge this though.

Copy link
Contributor

@jaydoane jaydoane left a comment

+1 LGTM

@nickva
nickva approved these changes Nov 13, 2018
Copy link
Contributor

@nickva nickva left a comment

+1

@wohali wohali merged commit caf021f into master Nov 13, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wohali wohali deleted the 1732-mango-tests-windows branch Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants