New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: port large_docs.js to Elixir test suite #1745

Merged
merged 2 commits into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@dottorblaster
Copy link
Contributor

dottorblaster commented Nov 18, 2018

Overview

I just ported large_docs.js to the Elixir test suite.

Testing recommendations

Issue make elixir 馃槵

Related Issues or Pull Requests

None

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@van-mronov van-mronov referenced this pull request Nov 27, 2018

Merged

Check code format before running elixir test suite #1767

0 of 3 tasks complete
@wohali

This comment has been minimized.

Copy link
Member

wohali commented Nov 28, 2018

@dottorblaster Keeping in mind #1767, please re-run make elixir on this PR after rebasing on master and ensure that your new test conforms to the coding standard.

@jaydoane are you able to review this contribution as well? Much obliged if you can :)

@dottorblaster dottorblaster force-pushed the dottorblaster:port-large-docs-to-elixir branch from 0c6e2d9 to 93e2f5e Nov 28, 2018

@dottorblaster

This comment has been minimized.

Copy link
Contributor

dottorblaster commented Nov 28, 2018

@wohali rebased and checked, all set. Waiting for review and merge 馃憤

@garrensmith
Copy link
Member

garrensmith left a comment

1 small change and then I can merge

This is a port of the large_docs.js suite
"""

# Should we use `"X-Couch-Full-Commit":"false"` header here?

This comment has been minimized.

@garrensmith

garrensmith Nov 28, 2018

Member

Judging from what @jaydoane said in another PR I don't think so. So you can remove this commetn as well :)

This comment has been minimized.

@dottorblaster

dottorblaster Nov 28, 2018

Contributor

@garrensmith nice catch, done 馃憤

@dottorblaster dottorblaster force-pushed the dottorblaster:port-large-docs-to-elixir branch from 62ee055 to f7cf12c Nov 28, 2018

@garrensmith garrensmith merged commit eca8622 into apache:master Nov 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dottorblaster dottorblaster deleted the dottorblaster:port-large-docs-to-elixir branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment