Skip to content

/ couchdb

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch scripts to python3 #1764

Merged
merged 3 commits into from Nov 28, 2018
Merged

Switch scripts to python3 #1764

merged 3 commits into from Nov 28, 2018

Conversation

@nickva
Copy link
Contributor

@nickva nickva commented Nov 26, 2018

Switch to using Python 3 for scripts

This is a re-opening of #1639 to use a branch on ASF repo
@nickva nickva mentioned this pull request Nov 26, 2018
Closed
@nickva nickva force-pushed the switch-scripts-to-python3 branch 2 times, most recently from b3ca418 to 0edff7d Nov 26, 2018
nickva added 2 commits Oct 3, 2018
@nickva
Switch to python 3
2a3467d 
Ran 2to3 and fixed a few deprecated warnings

Issue #1632
@nickva
Run mango tests with Python 3
Loading status checks…
9870a7c 
Before we were ignoring venv setup in the Makefile, so update the test runner
to use that instead of pestering developers to install those dependencies by
hand.

Issue #1632
@nickva nickva force-pushed the switch-scripts-to-python3 branch from 0edff7d to 9870a7c Nov 26, 2018
@wohali wohali added this to the 2.3.0 milestone Nov 26, 2018
@wohali
Copy link
Member

@wohali wohali commented Nov 26, 2018

+1 but delayed slightly until I have time to update Makefile.win to match, and to ensure couchdb-glazier has all the right dependencies installed to create and run venvs. Should have time in the next day or two.
@wohali
wohali reviewed Nov 28, 2018
View changes
Makefile Outdated Show resolved Hide resolved
@wohali wohali force-pushed the switch-scripts-to-python3 branch 2 times, most recently from 25c1756 to 291bb68 Nov 28, 2018
@wohali
wohali approved these changes Nov 28, 2018
View changes
Copy link
Member

@wohali wohali left a comment •
edited

So I've pushed a change that removes use of virtualenv everywhere and replaces it with python3 -m venv since this requires no additional installation, and is fully documented and supported in Python 3.4 and newer.

EDIT: Unfortunately that's still not the case with Debian/Ubuntu, where you still must apt-get install python3-venv. After that it works.

With my minor changes, and assuming Travis is green, this is +1. FYI Windows make mango-test passes with flying colours too.

Our Debian/Ubuntu Jenkins VMs will need updates to have python3-venv installed, it looks like. I'll get on that.
@wohali wohali force-pushed the switch-scripts-to-python3 branch from 291bb68 to 60e0380 Nov 28, 2018
wohali added a commit to apache/couchdb-ci that referenced this pull request Nov 28, 2018
@wohali
[deb] add python3-venv pkg, see apache/couchdb#1764
Loading status checks…
7e5977e
@wohali wohali mentioned this pull request Nov 28, 2018
Merged
@wohali wohali force-pushed the switch-scripts-to-python3 branch 3 times, most recently from e7f815a to 283e1a1 Nov 28, 2018
wohali added a commit to apache/couchdb-ci that referenced this pull request Nov 28, 2018
@wohali
[deb] add python3-venv pkg, see apache/couchdb#1764
Loading status checks…
64ae22a
@wohali wohali force-pushed the switch-scripts-to-python3 branch from 283e1a1 to 3d11cae Nov 28, 2018
@wohali
Don't use activate script; Windows fixes
Loading status checks…
d0f76b9
@wohali wohali force-pushed the switch-scripts-to-python3 branch from 3d11cae to d0f76b9 Nov 28, 2018
wohali added a commit to apache/couchdb-ci that referenced this pull request Nov 28, 2018
@wohali
[deb] add python3-venv pkg, see apache/couchdb#1764
Loading status checks…
29ece63
wohali added a commit to apache/couchdb-ci that referenced this pull request Nov 28, 2018
@wohali
[deb] add python3-venv pkg, see apache/couchdb#1764
Loading status checks…
6ebc053
wohali added a commit to apache/couchdb-ci that referenced this pull request Nov 28, 2018
@wohali
Merge pull request #15 from apache/deb-python3-venv
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6b08743 
[deb] add python3-venv pkg, see apache/couchdb#1764
@wohali
Copy link
Member

@wohali wohali commented Nov 28, 2018

PR apache/couchdb-ci#15 landed. Just rebuilding Jenkins images now and uploading them to Docker Hub. Merging to master now; Jenkins will probably fail this run, but will succeed the next one.
@wohali wohali merged commit fd03aa4 into master Nov 28, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wohali wohali deleted the switch-scripts-to-python3 branch Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wohali wohali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@nickva @wohali