Fix for problem with "require"-ing a js module which ends in a line comment #19

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@maghoff
Contributor

maghoff commented Apr 28, 2012

"require"-ing a js module which ends in a line comment will fail with a mysterious error message, because the line comment will comment out surrounding code added in /share/server/util.js

This patch adds a newline to terminate comments that might appear at the end of module files.

Note that it doesn't help to add a newline to the end of the module file -- couchdb apparently strips that away.

@rnewson

This comment has been minimized.

Show comment Hide comment
@rnewson

rnewson Apr 28, 2012

Member

I would merge this immediately, but it seems our github integration isn't working so well today (there's no Merge button).

Member

rnewson commented Apr 28, 2012

I would merge this immediately, but it seems our github integration isn't working so well today (there's no Merge button).

dch added a commit to dch/couchdb that referenced this pull request Apr 30, 2012

Merged pull request #19 from @maghoff with thanks
Fix failed loading of CommonJS modules that end in a line comment.

dch added a commit to dch/couchdb that referenced this pull request Apr 30, 2012

Merged pull request #19 from @maghoff with thanks
Fix failed loading of CommonJS modules that end in a line comment.
@dch

This comment has been minimized.

Show comment Hide comment
@dch

dch Apr 30, 2012

Contributor

Hi Magnus, thanks, committed to 1.2.x and master. We're still sorting out our asf/github integration, could you close this PR now?

Contributor

dch commented Apr 30, 2012

Hi Magnus, thanks, committed to 1.2.x and master. We're still sorting out our asf/github integration, could you close this PR now?

@maghoff

This comment has been minimized.

Show comment Hide comment
@maghoff

maghoff May 1, 2012

Contributor

Sweet :) Closed.

Contributor

maghoff commented May 1, 2012

Sweet :) Closed.

@maghoff maghoff closed this May 1, 2012

rnewson pushed a commit to rnewson/couchdb that referenced this pull request Mar 10, 2013

rnewson pushed a commit to rnewson/couchdb that referenced this pull request Mar 10, 2013

asfgit pushed a commit that referenced this pull request Mar 15, 2013

Merge pull request #19 from cloudant-labs/1690-template-settings-from…
…-config

1690 template settings from config

robertkowalski pushed a commit to robertkowalski/couchdb that referenced this pull request Jul 11, 2014

Merge pull request #19 from cloudant-labs/1690-template-settings-from…
…-config

1690 template settings from config

strmpnk pushed a commit to strmpnk/couchdb that referenced this pull request Dec 9, 2014

Merge pull request #19 from basho/adt-test-less-dependant-on-timer
Make the tests less dependant on timer:sleep()

nickva pushed a commit to cloudant/couchdb that referenced this pull request Apr 21, 2017

Merge remote branch 'cloudant:3135-remove_config_subscribe_from_couch…
…_index'

This closes #19

Signed-off-by: ILYA Khlopotov <iilyak@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment