Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix couchup for python3 #1905

Merged
merged 2 commits into from Feb 7, 2019
Merged

fix couchup for python3 #1905

merged 2 commits into from Feb 7, 2019

Conversation

@klaemo
Copy link
Contributor

@klaemo klaemo commented Feb 5, 2019

A tale of strings, bytes and pyhon3, I guess. This is probably the first line of python I've written in my life. Hooray! 馃榾 I consulted this fun document to understand what's going on.

Overview

couchup crashed in python3, because base64.b64encode expects a bytes-like object instead of a string. With this PR the string passed to base64.b64encode is properly encoded and decoded.

Testing recommendations

Run couchup with credentials with python3:
couchup replicate -a --login admin --password <my-password>

I was able to run couchup successfully on my DB with the change applied.

Related Issues or Pull Requests

fixes #1899

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
wohali
wohali approved these changes Feb 5, 2019
@wohali
Copy link
Member

@wohali wohali commented Feb 5, 2019

@klaemo Unfortunately I can't merge this because our style checker is failing. If you run sudo pip3 install black then make python-black-update and update your PR, it should solve the problem.

Thanks again for your PR!

Loading

A tale of strings, bytes and pyhon3, I guess
@klaemo
Copy link
Contributor Author

@klaemo klaemo commented Feb 6, 2019

@wohali Done! Sorry I missed this step.

Loading

@wohali wohali merged commit e702598 into apache:master Feb 7, 2019
1 check passed
Loading
janl added a commit that referenced this issue Feb 7, 2019
@klaemo klaemo deleted the patch-1 branch Feb 7, 2019
@wohali wohali mentioned this pull request Feb 7, 2019
janl added a commit that referenced this issue Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants