Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Trunk #30

Closed
wants to merge 2 commits into from

9 participants

@mikeymckay

Two commits. One is an attempt to improve documentation. The other is to make the "complete" callback usable for the login function.

@fdmanana

Hi,

Apache projects don't work with pull requests. Github is just a read-only mirror of the official subversion repository.
Issues should be reported through Jira: https://issues.apache.org/jira/browse/COUCHDB

And btw, the patch seems correct to me.
Thanks :)

Grumble grumble!
I can't figure out how to submit a patch. I guess I will create an issue and pastie the patch.

Apache -1 for not using github!

@rnewson

Are there any tests to go with this?

A Pull Request is fine for couchdb now (changed recently). We're not fully integrated so you'll need to close it yourself after the merge.

@mikeymckay
@rnewson

Have a peek in share/www/script/test/auth_cache.js to see some login/logout assertions. The reason for the test is not just to prove your fix but also to prevent regressions.

The only other things needed for a perfect submission would be to update the CHANGES and NEWS file in the root of the project with a description of the fix. We use those files for the release notes so keeping it up to date and accurate will help us in our goal to turn out releases more regularly.

@rnewson

Suggest the test, if you can manage one, belongs to basics.js

@janl

nudge

@mikeymckay

I am just a user of jquery.couch.js who found something that was broken not really someone hacking on the couchdb source. I looked at auth_cache.js, but it's not clear to me how to run the tests or make my own. I use https://github.com/iriscouch/build-couchdb to get my couchdb running. If you let me know how to run the test suite I can see if I can figure out how to add a test for this.

@janl
  1. Start CouchDB
  2. Open http://127.0.0.1:5984/_utils
  3. Go to "Test Suite"
  4. Either run All Tests, or individual tests by clicking the arrow next to them

You can find the source for the test cases in share/www/script/test/.

Thanks for your help! Let us know if you have any more questions! :)

@nslater

What's the status of this PR?

@Humbedooh
Owner

Looks like this was merged, do you want me to close it?

@asfbot

Reply from Humbedooh on #couchdb-dev on Freenode (IRC):
Testing IRC, ignore :)

@nslater

@janl what say ye?

@janl

should be trivial to find out whether this was merged.

@nslater

It wasn't. The second commit is not on master.

@robertkowalski

I just wanted to add a test for the second commit.

The first commit is on master (thanks again), the second commit doesn't seem to be valid any more: https://github.com/apache/couchdb/blob/master/share/www/script/jquery.couch.js#L214-L216

I think we can close this?!

@robertkowalski

Oh, nevermind!

@robertkowalski

It seems that writing a test for it is not that trivial, but maybe I am missing something here? JSpec got the last update in 2009 - and does not support async operations as far as I understand.

@robertkowalski

Ok I got that sorted out: I will add the tests and the send it to https://github.com/apache/couchdb-jquery-couch/

@robertkowalski robertkowalski referenced this pull request in apache/couchdb-jquery-couch
Closed

Mocha tests & addition of complete callbacks for login/logout #2

@kxepal

@mikeymckay the fix is landed in apache/couchdb-jquery-couch repository, thanks for the patch! Could you close this PR please?

@mikeymckay mikeymckay closed this
@candeira candeira referenced this pull request from a commit in candeira/couchdb
@kxepal kxepal Merge remote-tracking branch 'iilyak/2540-Fix-broken-tests-for-couch_…
…replicator'

This closes #30
74eefe9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 16, 2011
  1. @mikeymckay
Commits on Aug 7, 2012
  1. @mikeymckay
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 1 deletion.
  1. +5 −1 share/www/script/jquery.couch.js
View
6 share/www/script/jquery.couch.js
@@ -237,6 +237,9 @@
} else {
alert("An error occurred logging in: " + resp.reason);
}
+ if (typeof options.complete === "function") {
+ options.complete();
+ }
}
});
},
@@ -861,7 +864,8 @@
* uploads/all/documentation/couchbase-api-design.html#couchbase-api-
* design_db-design-designdoc-view-viewname_get">docs for /db/
* _design/design-doc/_list/l1/v1</a>
- * @param {String} name View to run list against
+ * @param {String} name View to run list against (string should have
+ * the design-doc name followed by a slash and the view name)
* @param {ajaxSettings} options <a href="http://api.jquery.com/
* jQuery.ajax/#jQuery-ajax-settings">jQuery ajax settings</a>
*/
Something went wrong with that request. Please try again.