Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Trunk #30

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
9 participants
Contributor

mikeymckay commented Aug 7, 2012

Two commits. One is an attempt to improve documentation. The other is to make the "complete" callback usable for the login function.

Hi,

Apache projects don't work with pull requests. Github is just a read-only mirror of the official subversion repository.
Issues should be reported through Jira: https://issues.apache.org/jira/browse/COUCHDB

And btw, the patch seems correct to me.
Thanks :)

Owner

mikeymckay replied Aug 16, 2011

Grumble grumble!
I can't figure out how to submit a patch. I guess I will create an issue and pastie the patch.

Apache -1 for not using github!

Member

rnewson commented Aug 7, 2012

Are there any tests to go with this?

A Pull Request is fine for couchdb now (changed recently). We're not fully integrated so you'll need to close it yourself after the merge.

Contributor

mikeymckay commented Aug 7, 2012

Nope. I'm not sure what testing framework you use. Is there a guide?

I needed the change, so I made it and thought others might want it as well.

On Tue, Aug 7, 2012 at 6:36 PM, Robert Newson notifications@github.comwrote:

Are there any tests to go with this?

A Pull Request is fine for couchdb now (changed recently). We're not fully
integrated so you'll need to close it yourself after the merge.


Reply to this email directly or view it on GitHubhttps://github.com/apache/couchdb/pull/30#issuecomment-7569242.

Member

rnewson commented Aug 7, 2012

Have a peek in share/www/script/test/auth_cache.js to see some login/logout assertions. The reason for the test is not just to prove your fix but also to prevent regressions.

The only other things needed for a perfect submission would be to update the CHANGES and NEWS file in the root of the project with a description of the fix. We use those files for the release notes so keeping it up to date and accurate will help us in our goal to turn out releases more regularly.

Member

rnewson commented Aug 7, 2012

Suggest the test, if you can manage one, belongs to basics.js

Member

janl commented Nov 14, 2012

nudge

Contributor

mikeymckay commented Nov 15, 2012

I am just a user of jquery.couch.js who found something that was broken not really someone hacking on the couchdb source. I looked at auth_cache.js, but it's not clear to me how to run the tests or make my own. I use https://github.com/iriscouch/build-couchdb to get my couchdb running. If you let me know how to run the test suite I can see if I can figure out how to add a test for this.

Member

janl commented Nov 15, 2012

  1. Start CouchDB
  2. Open http://127.0.0.1:5984/_utils
  3. Go to "Test Suite"
  4. Either run All Tests, or individual tests by clicking the arrow next to them

You can find the source for the test cases in share/www/script/test/.

Thanks for your help! Let us know if you have any more questions! :)

@rnewson rnewson pushed a commit to rnewson/couchdb that referenced this pull request Mar 10, 2013

@kocolosk kocolosk Merge pull request #30 from cloudant/13606-node-info-ets
Publish node metadata in a protected ets table

BugzID: 13606
4704323
Member

nslater commented May 21, 2013

What's the status of this PR?

Owner

Humbedooh commented Feb 15, 2014

Looks like this was merged, do you want me to close it?

asfbot commented Feb 15, 2014

Reply from Humbedooh on #couchdb-dev on Freenode (IRC):
Testing IRC, ignore :)

Member

nslater commented Feb 19, 2014

@janl what say ye?

Member

janl commented Feb 19, 2014

should be trivial to find out whether this was merged.

Member

nslater commented Feb 19, 2014

It wasn't. The second commit is not on master.

Member

robertkowalski commented Jun 15, 2014

I just wanted to add a test for the second commit.

The first commit is on master (thanks again), the second commit doesn't seem to be valid any more: https://github.com/apache/couchdb/blob/master/share/www/script/jquery.couch.js#L214-L216

I think we can close this?!

Member

robertkowalski commented Jun 15, 2014

Oh, nevermind!

Member

robertkowalski commented Jun 16, 2014

It seems that writing a test for it is not that trivial, but maybe I am missing something here? JSpec got the last update in 2009 - and does not support async operations as far as I understand.

Member

robertkowalski commented Jun 16, 2014

Ok I got that sorted out: I will add the tests and the send it to https://github.com/apache/couchdb-jquery-couch/

@robertkowalski robertkowalski referenced this pull request in apache/couchdb-jquery-couch Jun 16, 2014

Closed

Mocha tests & addition of complete callbacks for login/logout #2

Member

kxepal commented Oct 31, 2014

@mikeymckay the fix is landed in apache/couchdb-jquery-couch repository, thanks for the patch! Could you close this PR please?

@mikeymckay mikeymckay closed this Oct 31, 2014

@candeira candeira pushed a commit to candeira/couchdb that referenced this pull request Apr 6, 2015

@kxepal kxepal Merge remote-tracking branch 'iilyak/2540-Fix-broken-tests-for-couch_…
…replicator'

This closes #30
74eefe9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment