Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support OTP-18.0 #325

Merged
merged 1 commit into from Jun 26, 2015
Merged

build: support OTP-18.0 #325

merged 1 commit into from Jun 26, 2015

Conversation

dch
Copy link
Contributor

@dch dch commented Jun 26, 2015

Support OTP-18.0.

configure & make checks LGTM, would be nice if somebody can check a linux?

A few more warnings appear as expected, crypto & time stuff.

erlang:now/0 as we know
calendar:local_time_to_universal_time/1 -> calendar:local_time_to_universal_time_dst/1
crypto:sha_mac/2 -> crypto:hmac/3
crypto:sha/1 -> crypto:hash/2
crypto:md5_init/0 -> crypto:hash_init/1
crypto:md5_update/0 -> crypto:hash_update/1
crypto:md5_final/0 -> crypto:hash_final/1

@rnewson
Copy link
Member

rnewson commented Jun 26, 2015

+1

@kxepal
Copy link
Member

kxepal commented Jun 26, 2015

+1 works for me on Gentoo Linux

P.S. We also have another issue with building 1.x:

gcc -DHAVE_CONFIG_H -I. -I../../.. -I../../../src/snappy/google-snappy   -D_XOPEN_SOURCE  -I/opt/local/include -I/opt/local/include/js -I/usr/local/include -I/usr/local/include/js -I/usr/include -I/usr/include/js  -g -Wall -Werror -D_BSD_SOURCE  -DXP_UNIX -I/usr/include/js -I/usr/include/nspr  -O2 -g -O2 -MT couch_js/couchjs-http.o -MD -MP -MF couch_js/.deps/couchjs-http.Tpo -c -o couch_js/couchjs-http.o `test -f 'couch_js/http.c' || echo './'`couch_js/http.c
In file included from /usr/include/stdio.h:27:0,
                 from couch_js/http.c:13:
/usr/include/features.h:148:3: error: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Werror=cpp]
 # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
   ^
cc1: all warnings being treated as errors
Makefile:670: recipe for target 'couch_js/couchjs-http.o' failed

@dch could you check if such warning fix is fine for FreeBSD?

@asfgit asfgit merged commit 95cb436 into apache:1.6.x Jun 26, 2015
@dch
Copy link
Contributor Author

dch commented Jun 26, 2015

@kxepal this seems to be a linux issue according to https://lists.freebsd.org/pipermail/freebsd-standards/2004-March/000474.html FWIW I am building after running perl -pi -e 's/_BSD_SOURCE/_DEFAULT_SOURCE/g' src/couchdb/priv/Makefile.am src/ejson/Makefile.am src/snappy/Makefile.am test/etap/Makefile.am to clean those up, so far the build seems OK. gmake check takes a while...

./test/etap/210-os-proc-pool.t .................... ok
./test/etap/220-compaction-daemon.t ............... ok
./test/etap/230-pbkfd2.t .......................... ok
./test/etap/231-cors.t ............................ ok
./test/etap/250-upgrade-legacy-view-files.t ....... ok
All tests successful.
Files=51, Tests=1215, 285 wallclock secs ( 0.40 usr  0.03 sys + 76.33 cusr  9.47 csys = 86.23 CPU)
Result: PASS

woohoo!

nickva pushed a commit to nickva/couchdb that referenced this pull request Sep 7, 2022
* fix formatting, closes apache#310
* Clarify cluster setup wizard, closes apache#325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants