Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] JS tests on 2.0 — DO NOT MERGE YET #354

Closed
wants to merge 14 commits into from

Conversation

janl
Copy link
Member

@janl janl commented Oct 7, 2015

No description provided.

…details

- tests that are broken now print one of three things:
  - TODO: means the cause of breakage is still to be determiend
  - TODO <text>: the cause of breakage is known
  - Error <text>: the cause of breakate is known
    - `Error: _config not available on cluster`, which unfortunately
       are a lot, because run_on_modified_server uses it

Assorted issues found:

- _all_docs update_seq :true option missing (needs fix)
- invalid_docid error messages changed from `bad_request` to `illegal_docid` (fixed, must be noted in BREAKING CHANGES)
- OPTIONS for list view not allowed (needs fix)
- _purge: this feature is not yet implemented (needs impl)
- all_or_nothing is gone! (fixed, needs to be noted in BREAKING CHANGES)
@sebastianrothbucher
Copy link
Contributor

I got a little further (up to "r" ;-) ). Still have to dig a little more into your work. Maybe we can copy over missing parts from my branch (didn't jet submit a PR anyway): master...sebastianrothbucher:clustertest

req = CouchDB.request("GET", "/test_suite_db/_changes?feed=eventsource&timeout=0&since=0",
{"headers": {"Accept": "text/event-stream", "Last-Event-ID": "2"}});
req = CouchDB.request("GET", "/" + db_name + "/_changes?feed=eventsource&timeout=0&since=0",
{"headers": {"Accept": "text/event-stream", "Last-Event-ID": JSON.stringify(JSON.parse(req.responseText).results[1].seq)}});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See apache/couchdb-chttpd#89 . I made this value completely opaque as it was before, so there is no need to JSON encode seq for Last-Event-ID header. However, we can discuss this moment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a PR: janl#4

@wohali
Copy link
Member

wohali commented Mar 19, 2017

@janl I think this is outdated, can we close?

@sebastianrothbucher
Copy link
Contributor

as far as I can remember, we can indeed close it (leaving it up 2 @janl still)

@wohali wohali closed this Apr 30, 2017
lag-linaro pushed a commit to lag-linaro/couchdb that referenced this pull request Oct 25, 2018
janl pushed a commit that referenced this pull request Jan 5, 2020
nickva pushed a commit to nickva/couchdb that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants