Always commit if we upgrade 2.x view files#5030
Merged
Merged
Conversation
rnewson
approved these changes
Apr 10, 2024
janl
approved these changes
Apr 10, 2024
When we upgrade empty view files from 2.x, we end up skipping the commit. Subsequently, we will see a "wrong signature" error when the view is opened later. The error is benign as we'd end up resetting an empty view, but it may surprise an operator. To avoid this, ensure to always commit after upgrading old views. Issue: #4994
nickva
force-pushed
the
always-commit-if-we-upgrade-the-old-signature
branch
from
025eff0 to
f3d7939
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we upgrade empty view files from 2.x, we end up skipping the commit. Subsequently, we will see a "wrong signature" error when the view is opened later. The error is benign as we'd end up resetting an empty view, but it may surprise an operator. To avoid this, ensure to always commit after upgrading old views.
Issue: #4994