Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Return 409 when put attachment with nonexistent rev #595
Currently we return a 500 and something like
This changes the behavior to return a 409 and
Test is included with PR
GitHub issue number
Related Pull Requests
The tests are fine locally and
The only thing is that I'm not 100% sure that we should return
I'm tentatively +1, but get a second opinion before merging, please.
make eunit apps=chttpd ... ======================================================= All 150 tests passed.
I think I lean more toward @eiri's idea of making it a 409.
The document itself is there it's just that the revision doesn't match. This is similar to updating a regular document (not an attachment) with an revision which doesn't match where we get a 409.
Now if database is altogether missing then we do get a 404. But I think this is closer to the former than the later.
Also +1. Nice work!