New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compaction daemon by default #624

Merged
merged 2 commits into from Jul 6, 2017

Conversation

Projects
None yet
2 participants
@janl
Member

janl commented Jun 29, 2017

This is the #1 potential user footgun we ship by default. Especially with _global_changes coming on the scene, this becomes quite the annoying issue. Pro-users can easily disable it, most users will want to have it enabled.

@janl janl added the feature label Jun 29, 2017

@wohali

This comment has been minimized.

Show comment
Hide comment
@wohali

wohali Jun 29, 2017

Member

zOMG +1...except the tests are all failing in compaction now. What gives? Is this feature broken?

Member

wohali commented Jun 29, 2017

zOMG +1...except the tests are all failing in compaction now. What gives? Is this feature broken?

@janl

This comment has been minimized.

Show comment
Hide comment
@janl

janl Jun 29, 2017

Member

Heh, the tests might assume the feature to be off, I'll check in the morning :)

The feature works fine.

Member

janl commented Jun 29, 2017

Heh, the tests might assume the feature to be off, I'll check in the morning :)

The feature works fine.

@wohali

This comment has been minimized.

Show comment
Hide comment
@wohali

wohali Jul 4, 2017

Member

@janl +1, do it!

Member

wohali commented Jul 4, 2017

@janl +1, do it!

@wohali wohali added this to the 2.1.0 milestone Jul 4, 2017

@janl janl merged commit 8b127f4 into master Jul 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@janl janl deleted the feat/enable-compaction-daemon-by-default branch Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment