New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

649 fix mrview changes since test #667

Merged
merged 2 commits into from Jul 13, 2017

Conversation

Projects
None yet
3 participants
@davisp
Member

davisp commented Jul 12, 2017

Fixes for #649

@nickva

This comment has been minimized.

Show comment
Hide comment
@nickva

nickva Jul 12, 2017

Contributor

+1

Nice find - two bugs with one PR!

Took a while for me to understand what's happening since not familiar with this part of code.

Tests look good. One failure but in a different area.

Contributor

nickva commented Jul 12, 2017

+1

Nice find - two bugs with one PR!

Took a while for me to understand what's happening since not familiar with this part of code.

Tests look good. One failure but in a different area.

davisp added some commits Jul 12, 2017

Prevent a terrible race condition
Looking into #649 I realized there's a pretty terrible race condition if
an index is compacted quickly followed by an index update. Since we
don't check the index updater message it would be possible for us to
swap out a compaction change, followed by immediately resetting to the
new state from the index updater. This would be bad as we'd possibly end
up with a situation where our long lived index would be operating on a
file that no longer existed on disk.
Avoid a race when restarting an index updater
This was encountered during the test suite runs on Travis. It turns out
that when we restart the indexer its possible to already have the 'EXIT'
message in our mailbox. When we do we'll then crash with an unknown_info
error since our updater pid was changed during the restart.

This change simple filters any 'EXIT' message from the old updater from
the mailbox before restarting thew new index updater.

Fixes #649

@davisp davisp merged commit 6586102 into master Jul 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@davisp davisp deleted the 649-fix-mrview-changes-since-test branch Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment