Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow replicator application to always update replicator docs #738
It might be invalid if user already had a document which is malformed, they updated to the new code and replicator is trying to update their document indicating to the user their document is malformed. But it can't update because the VDU is too strict.
And it crashes the replicator application...
The alternative could be to catch and log the error but then the user might never find out about it
It depends on the update_docs compatibility option. If that is enabled then we'd be updating the document with the error state like before then retrying again. If it is disabled then we'd only updated the document with the failed and completed states. Both of which are terminal and after that we forget about that document.