Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support setting cookie domain for auth #827
Implementation for https://issues.apache.org/jira/browse/COUCHDB-1959
It's a very simple use where you can set cookie_domain in the config which gets put on the set-cookie header.
I couldn't work out where the documentation is to update that and I'm not familiar enough with Erlang to write a test for it but a manual test with and without the config value works fine. If anyone wants to point out how to make a test for it I'm happy enough to put it in if desired.
I've been using this build myself for dev since making the pull request and it all works as expected on port 5984.
With the tests I can see how the login is handled easy enough but I can't work out how the server is started since I guess it would have to be restarted with different a config to test the domain gets set on the cookie correctly.
Hi @almightyju , I'd like to push forward with this. I also want you to get the credit for the change!
You don't have to restart the server with a different config, just change it as part of your
If you need more guidance, I'm happy to work together with you on this, just let me know.