New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stats interval into config parameter #830

Merged
merged 2 commits into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@eiri
Member

eiri commented Sep 21, 2017

Overview

This patch converts collection_interval setting for couch_stats from app's env to couch config parameter.

Testing recommendations

Test suite should pass

GitHub issue number

Closes #811

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
@nickva

This comment has been minimized.

Show comment
Hide comment
@nickva

nickva Sep 25, 2017

Contributor

+1 (but see note first about config).

Checked with tracing that setting interval to 3 seconds via config ends up with aggregator calling collect every 3 seconds.

Contributor

nickva commented Sep 25, 2017

+1 (but see note first about config).

Checked with tracing that setting interval to 3 seconds via config ends up with aggregator calling collect every 3 seconds.

@eiri

This comment has been minimized.

Show comment
Hide comment
@eiri

eiri Sep 25, 2017

Member

Hey @nickva thank you for the review. I've moved defaults in private header file. Do you find this an acceptable alternative to suggested API call?

Member

eiri commented Sep 25, 2017

Hey @nickva thank you for the review. I've moved defaults in private header file. Do you find this an acceptable alternative to suggested API call?

@nickva

This comment has been minimized.

Show comment
Hide comment
@nickva

nickva Sep 25, 2017

Contributor

@eiri that will work, good idea!

Contributor

nickva commented Sep 25, 2017

@eiri that will work, good idea!

@nickva

nickva approved these changes Sep 25, 2017

@eiri eiri merged commit 3b8b9a3 into apache:master Sep 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eiri eiri deleted the cloudant:issue-811-configure-collection_interval branch Sep 25, 2017

willholley added a commit to willholley/couchdb that referenced this pull request May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment