New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist some config sections from HTTP PUT/DELETE operations #914

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
4 participants
@wohali
Member

wohali commented Oct 25, 2017

Covers clustered and node-local ports.

Includes JS test for clustered port.

@wohali wohali requested review from janl and rnewson Oct 25, 2017

@janl

janl approved these changes Oct 25, 2017

@wohali wohali removed the request for review from rnewson Oct 25, 2017

@wohali wohali merged commit 82635ef into master Oct 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wohali wohali deleted the blacklist-config-sections branch Oct 25, 2017

kxepal added a commit to kxepal/couchdb that referenced this pull request Oct 25, 2017

kxepal added a commit to kxepal/couchdb that referenced this pull request Oct 26, 2017

kxepal added a commit to kxepal/couchdb that referenced this pull request Oct 26, 2017

janl added a commit that referenced this pull request Oct 31, 2017

@ondra-novak

This comment has been minimized.

Show comment
Hide comment
@ondra-novak

ondra-novak Nov 12, 2017

Is there some way to remove blacklist? I am heavily using os_daemons to start/stop daemons by http

ondra-novak commented Nov 12, 2017

Is there some way to remove blacklist? I am heavily using os_daemons to start/stop daemons by http

@kxepal

This comment has been minimized.

Show comment
Hide comment
@kxepal

kxepal Nov 12, 2017

Member

@ondra-novak
Suddenly, no - it's a security measurement. However, for 2.x you still can manage os_daemons in runtime by modifying config file and reloading it via /_config/_reload, IIRC. You can setup special externals which will do that for you. But, it's all for your own risk.

Member

kxepal commented Nov 12, 2017

@ondra-novak
Suddenly, no - it's a security measurement. However, for 2.x you still can manage os_daemons in runtime by modifying config file and reloading it via /_config/_reload, IIRC. You can setup special externals which will do that for you. But, it's all for your own risk.

@ondra-novak

This comment has been minimized.

Show comment
Hide comment
@ondra-novak

ondra-novak Nov 12, 2017

OK, so I will need to put some http server there....

<irony>oh boy, please make things more complicated next time</irony>

ondra-novak commented Nov 12, 2017

OK, so I will need to put some http server there....

<irony>oh boy, please make things more complicated next time</irony>
@wohali

This comment has been minimized.

Show comment
Hide comment
@wohali

wohali Nov 12, 2017

Member

We know this change is frustrating for your specific use case, but there is a good reason for this change.

Again, insulting members of our project team doesn't help anyone. I ask you again to abide by our Code of Conduct.

Member

wohali commented Nov 12, 2017

We know this change is frustrating for your specific use case, but there is a good reason for this change.

Again, insulting members of our project team doesn't help anyone. I ask you again to abide by our Code of Conduct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment