New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable eval() and Function() constructor in JS by default #916

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@wohali
Member

wohali commented Oct 25, 2017

This changes the couchjs --no-eval flag to --eval and disables
eval() and Function() constructors by default in couchjs.

As this is a major change to compatibility, it should land in the next feature release, not 2.1.1.

A documentation PR will come after this lands.

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@wohali wohali requested review from davisp and tilgovi Oct 25, 2017

@davisp

davisp approved these changes Oct 25, 2017

+1

Disable eval() and Function() constructor in JS by default
This changes the couchjs --no-eval flag to --eval and disables
eval() and Function() constructors by default in couchjs.

@wohali wohali merged commit 1cd5852 into master Oct 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wohali wohali deleted the js-no-eval-default branch Oct 26, 2017

@wohali wohali referenced this pull request Aug 8, 2018

Closed

list functions in v2.2.0 #1544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment