CURATOR-544 - Fix issue with 'error code' 0 being passed to the Keepe…

…rExeception create method. This was breaking a lot of code
apache · May 8, 2020 · 5d569518ea617f30296fd3ca983034940a26529d · 5d56951
1 parent 092c1e3
commit 5d569518ea617f30296fd3ca983034940a26529d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java b/curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
@@ -637,7 +637,8 @@ <DATA_TYPE> void processBackgroundOperation(OperationAndData<DATA_TYPE> operatio
         boolean doQueueOperation = false;
         do
         {
-            if ( getZookeeperClient().getRetryPolicy().allowRetry(KeeperException.create(event.getResultCode())) )
+            KeeperException.Code code = KeeperException.Code.get(event.getResultCode());
+            if ( (code != KeeperException.Code.OK) && getZookeeperClient().getRetryPolicy().allowRetry(KeeperException.create(code)) )
             {
                 doQueueOperation = checkBackgroundRetry(operationAndData, event);
                 break;