Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURATOR-523: Fix ByteBuffer's compatibility issues #321

Merged
merged 1 commit into from Aug 22, 2019
Merged

CURATOR-523: Fix ByteBuffer's compatibility issues #321

merged 1 commit into from Aug 22, 2019

Conversation

@asdf2014
Copy link
Member

@asdf2014 asdf2014 commented Aug 1, 2019

No description provided.

@asdf2014
Copy link
Member Author

@asdf2014 asdf2014 commented Aug 1, 2019

Loading

@pacomendes
Copy link

@pacomendes pacomendes commented Aug 1, 2019

Thanks, LGTM

Loading

@leventov
Copy link
Member

@leventov leventov commented Aug 2, 2019

LGTM, although I don't see how the diff relates to the title of the PR.

Loading

@asdf2014
Copy link
Member Author

@asdf2014 asdf2014 commented Aug 2, 2019

@pacomendes @leventov Thank you for your comments. This title is mainly used to indicate that the underlying purpose of this PR is to resolve ByteBuffer compatibility issues caused by the JDK version. 😅

Loading

@asdf2014
Copy link
Member Author

@asdf2014 asdf2014 commented Aug 21, 2019

@shayshim Can we move this forward? Apache Druid wants to upgrade to the new version of Curator, but it was blocked by this issue. More details: apache/druid#8177

Loading

@pacomendes
Copy link

@pacomendes pacomendes commented Aug 21, 2019

@Randgalt can we merge this in?

Loading

@Randgalt
Copy link
Member

@Randgalt Randgalt commented Aug 21, 2019

I'll try to get to it soon. Or maybe @shayshim or @cammckenzie can do it.

Loading

@shayshim
Copy link
Contributor

@shayshim shayshim commented Aug 21, 2019

@Randgalt @asdf2014 I can get to it soon too

Loading

@shayshim shayshim merged commit db399d4 into apache:master Aug 22, 2019
1 check passed
Loading
@asdf2014 asdf2014 deleted the fix_bytebuffer branch Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants