Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURATOR-523: Fix ByteBuffer's compatibility issues #321

Open
wants to merge 1 commit into
base: master
from

Conversation

@asdf2014
Copy link
Member

commented Aug 1, 2019

No description provided.

@asdf2014

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

@pacomendes

This comment has been minimized.

Copy link

commented Aug 1, 2019

Thanks, LGTM

@leventov

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

LGTM, although I don't see how the diff relates to the title of the PR.

@asdf2014

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

@pacomendes @leventov Thank you for your comments. This title is mainly used to indicate that the underlying purpose of this PR is to resolve ByteBuffer compatibility issues caused by the JDK version. 😅

@asdf2014

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

@shayshim Can we move this forward? Apache Druid wants to upgrade to the new version of Curator, but it was blocked by this issue. More details: apache/incubator-druid#8177

@pacomendes

This comment has been minimized.

Copy link

commented Aug 21, 2019

@Randgalt can we merge this in?

@Randgalt

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

I'll try to get to it soon. Or maybe @shayshim or @cammckenzie can do it.

@shayshim

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

@Randgalt @asdf2014 I can get to it soon too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.