Skip to content
Permalink
Browse files
CI and Lint Updates:
- Create one-commit CI.
- Create formatting.yml for run the linting of the typescript, javascript and scala code.
- Update project/plugins ScalaFMT for linting purposes.
- Fix lint script in package.json to use prettier instead of eslint
- Create .prettierignore to have prettier ignore certain files
- Remove eslint files/packages as we are using prettier.
- Update extensions.json to recommeded the prettier extension instead of the eslint extension.
- Remove unnecessaary eslint packages from yarn.lock
- Remove eslint ignore line in daffodilDebug
- Remove lint from npm-test -- This causes windows npm test to break because of the difference in line endings
- Remove release.yml
- Remove "eamodio.tsl-problem-matcher" from recommened extensions list as it not longer exists

Closes #45
Closes #46
  • Loading branch information
Shanedell committed Jan 15, 2022
1 parent 4c7bcf2 commit 6c0f29eb7f1353277d120eccadc4a5cccc44622f
Showing 19 changed files with 830 additions and 1,175 deletions.

This file was deleted.

@@ -0,0 +1,54 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

---
name: Code Formatting
on:
push:
branches-ignore: [ 'dependabot/**' ]
pull_request:
types: [opened, synchronize, reopened]

jobs:
ts-format:
name: TypeScript Formatting
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2.3.5
- name: Setup Node
uses: actions/setup-node@v1.4.6
with:
node-version: '16'
- run: yarn install
- run: yarn lint

scala-format:
name: Scala Formatting
runs-on: ubuntu-20.04
defaults:
run:
shell: bash
env:
SBT: sbt -J-Xms1024m -J-Xmx5120m -J-XX:ReservedCodeCacheSize=512m -J-XX:MaxMetaspaceSize=1024m ++2.12.13

steps:
- uses: actions/checkout@v2.3.5
- name: Setup Java
uses: actions/setup-java@v2.3.1
with:
distribution: temurin
java-version: 11
- run: $SBT scalafmtCheck
- run: $SBT scalafmtSbtCheck
@@ -0,0 +1,43 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

---
name: Single Commit PR

on:
push:
branches-ignore: [ 'dependabot/**' ]
pull_request:
types: [opened, synchronize, reopened]


jobs:
single-commit:
name: Single Commit Pull Request
if: github.event_name == 'pull_request'
runs-on: ubuntu-20.04
steps:
- name: Check Single Commit
uses: actions/github-script@v5.0.0
with:
script: |
const commits = await github.rest.pulls.listCommits({
...context.repo,
pull_number: context.issue.number,
});
core.info("Number of commits in this pull request: " + commits.data.length);
if (commits.data.length > 1) {
core.setFailed("If approved with two +1's, squash this pull request into one commit");
}

This file was deleted.

@@ -18,3 +18,5 @@ build
coverage
out
dist

version.ts
@@ -19,7 +19,6 @@
// See http://go.microsoft.com/fwlink/?LinkId=827846
// for the documentation about the extensions.json format
"recommendations": [
"dbaeumer.vscode-eslint",
"eamodio.tsl-problem-matcher"
"esbenp.prettier-vscode"
]
}
@@ -24,7 +24,7 @@
"request": "launch",
"args": [
"--extensionDevelopmentPath=${workspaceFolder}",
"${workspaceFolder}/sampleWorkspace"
"${workspaceFolder}/../sampleWorkspace"
],
"outFiles": [
"${workspaceFolder}/dist/ext/**/*.js"
@@ -29,6 +29,14 @@
"files.watcherExclude": {
"**/target": true
},
"[css]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true
},
"[javascript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true
},
"[typescript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true

0 comments on commit 6c0f29e

Please sign in to comment.