New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests and CI #21
Comments
When this is added, I suggest you base it off of the Daffodil file. Specifically, ignoring dependabot branches, test matrices (if needed), Apahce Rat check, Single commit PR, etc. |
@stevedlawrence I was working on this one and was trying to follow the However when it comes to the Apache Rat Check, would we want to get that setup as separate PR? I think I could easily get that stuff added in but I wanted to see how thought best to approach this? I did notice the comment on #26 about this so wanted to make sure to verify best solution. Do you want the CI for this project to be the same as |
I'm fine with Rat being a separate PR. In Daffodil we did have a couple separate yml files, but we eventually combined into a single file. We found it reduced duplication and made it a bit easier to manage and visually everything that is checked in a PR. So I'd lean towards that. But this is a different project so if that doesn't make sense I'm open to alternatives. But the more similar things are, the easier it is for people to switch become familiar with both projects. |
That makes sense, do you think it would be best for us to keep them separate for the time being then once we have the pieces we want in the CI we can merge them together? |
I have no strong preference. It'll probably be easier to make suggestions once we see the actual checks (it's not totally clear to me what is involved with CI for this vscode project). So I suggest do what you feel is right, and once we have something concrete to look at we can determine if there's a better way to organize things. |
…nning the unit tests. Closes issue #21
…nning the unit tests. Closes issue #21
…fodil-debug (apache#21) update the downloading of the debugger files into the home directory to work on windows delete some bad white space and comments update location of the downloaded files to go to tmp folder using os.tmpdir update location of downloaded files fix data directory name ` get rid of information message
The unit tests and workflow configuration were removed in jw3/example-daffodil-vscode@92d5c7d to simplify licensing for the move.
These need added back, while this time using schema and test data that are license compatible with this repo.
The text was updated successfully, but these errors were encountered: