Fix ULong. ULong.MaxValue is wrong.#571
Merged
Merged
Conversation
Merged
tuxji
approved these changes
May 20, 2021
Contributor
tuxji
left a comment
tuxji
left a comment
There was a problem hiding this comment.
+1
I wanted the CI checks to run before I reviewed, but something seems to be holding up the last three jobs that should have finished by now (they are still waiting to be run). The changes look good to me anyway.
Add more tests to cover this. DAFFODIL-2522
Contributor
Author
|
The checks system keeps hanging. I'm merging this anyway, as I have tested it locally, and it is a small focused change. |
Member
|
Yeah, GitHub actions is having issues: https://www.githubstatus.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more tests to cover this.
DAFFODIL-2522