From 78412c736a469c1eec03ad38c4ff9a6bee77d3f4 Mon Sep 17 00:00:00 2001 From: Andy Grove Date: Tue, 21 Apr 2026 09:52:18 -0600 Subject: [PATCH 1/2] chore: skip Iceberg and Spark SQL test workflows on test-only changes Extend paths-ignore in iceberg_spark_test.yml and spark_sql_test.yml so PRs that touch only Comet's own test code or resources do not trigger these external-project test workflows. Adds spark/src/test/**, common/src/test/**, fuzz-testing/**, spark-integration/**, and dev/** to the ignore list. The broader spark/src/test/** pattern subsumes the previous benchmark-only entry. --- .github/workflows/iceberg_spark_test.yml | 12 ++++++++++-- .github/workflows/spark_sql_test.yml | 12 ++++++++++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/.github/workflows/iceberg_spark_test.yml b/.github/workflows/iceberg_spark_test.yml index bb857c9e87..e2db76014e 100644 --- a/.github/workflows/iceberg_spark_test.yml +++ b/.github/workflows/iceberg_spark_test.yml @@ -32,7 +32,11 @@ on: - "**.md" - "native/core/benches/**" - "native/spark-expr/benches/**" - - "spark/src/test/scala/org/apache/spark/sql/benchmark/**" + - "spark/src/test/**" + - "common/src/test/**" + - "fuzz-testing/**" + - "spark-integration/**" + - "dev/**" pull_request: paths-ignore: - "benchmarks/**" @@ -41,7 +45,11 @@ on: - "**.md" - "native/core/benches/**" - "native/spark-expr/benches/**" - - "spark/src/test/scala/org/apache/spark/sql/benchmark/**" + - "spark/src/test/**" + - "common/src/test/**" + - "fuzz-testing/**" + - "spark-integration/**" + - "dev/**" # manual trigger # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow workflow_dispatch: diff --git a/.github/workflows/spark_sql_test.yml b/.github/workflows/spark_sql_test.yml index 61e36a0063..01c549d3f9 100644 --- a/.github/workflows/spark_sql_test.yml +++ b/.github/workflows/spark_sql_test.yml @@ -32,7 +32,11 @@ on: - "**.md" - "native/core/benches/**" - "native/spark-expr/benches/**" - - "spark/src/test/scala/org/apache/spark/sql/benchmark/**" + - "spark/src/test/**" + - "common/src/test/**" + - "fuzz-testing/**" + - "spark-integration/**" + - "dev/**" pull_request: paths-ignore: - "benchmarks/**" @@ -41,7 +45,11 @@ on: - "**.md" - "native/core/benches/**" - "native/spark-expr/benches/**" - - "spark/src/test/scala/org/apache/spark/sql/benchmark/**" + - "spark/src/test/**" + - "common/src/test/**" + - "fuzz-testing/**" + - "spark-integration/**" + - "dev/**" # manual trigger # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow workflow_dispatch: From 097616a94948c35e8589f03621eef16a19f9abf2 Mon Sep 17 00:00:00 2001 From: Andy Grove Date: Tue, 21 Apr 2026 09:56:56 -0600 Subject: [PATCH 2/2] chore: drop dev/** from paths-ignore The dev/ directory contains Spark source diffs applied to the external Spark checkout, so changes there can affect Spark SQL test behavior. --- .github/workflows/iceberg_spark_test.yml | 2 -- .github/workflows/spark_sql_test.yml | 2 -- 2 files changed, 4 deletions(-) diff --git a/.github/workflows/iceberg_spark_test.yml b/.github/workflows/iceberg_spark_test.yml index e2db76014e..4d6200c7ad 100644 --- a/.github/workflows/iceberg_spark_test.yml +++ b/.github/workflows/iceberg_spark_test.yml @@ -36,7 +36,6 @@ on: - "common/src/test/**" - "fuzz-testing/**" - "spark-integration/**" - - "dev/**" pull_request: paths-ignore: - "benchmarks/**" @@ -49,7 +48,6 @@ on: - "common/src/test/**" - "fuzz-testing/**" - "spark-integration/**" - - "dev/**" # manual trigger # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow workflow_dispatch: diff --git a/.github/workflows/spark_sql_test.yml b/.github/workflows/spark_sql_test.yml index 01c549d3f9..e1fddda9b0 100644 --- a/.github/workflows/spark_sql_test.yml +++ b/.github/workflows/spark_sql_test.yml @@ -36,7 +36,6 @@ on: - "common/src/test/**" - "fuzz-testing/**" - "spark-integration/**" - - "dev/**" pull_request: paths-ignore: - "benchmarks/**" @@ -49,7 +48,6 @@ on: - "common/src/test/**" - "fuzz-testing/**" - "spark-integration/**" - - "dev/**" # manual trigger # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow workflow_dispatch: