From ec6072090932bd7b30ee441265b77b6aee610929 Mon Sep 17 00:00:00 2001 From: nick young Date: Thu, 25 Sep 2025 08:03:57 -0700 Subject: [PATCH 1/4] Update databricks.rs --- src/dialect/databricks.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/dialect/databricks.rs b/src/dialect/databricks.rs index a3476b1b8..ad933873d 100644 --- a/src/dialect/databricks.rs +++ b/src/dialect/databricks.rs @@ -64,4 +64,9 @@ impl Dialect for DatabricksDialect { fn supports_struct_literal(&self) -> bool { true } + + // See https://docs.databricks.com/en/sql/language-manual/sql-ref-syntax-qry-select-groupby.html + fn supports_group_by_with_modifier(&self) -> bool { + true + } } From d8c2e1a44df01b3846c94f2945201c40bb950294 Mon Sep 17 00:00:00 2001 From: nick young Date: Fri, 26 Sep 2025 08:15:05 -0700 Subject: [PATCH 2/4] Update src/dialect/databricks.rs Co-authored-by: Ifeanyi Ubah --- src/dialect/databricks.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dialect/databricks.rs b/src/dialect/databricks.rs index ad933873d..37197ae50 100644 --- a/src/dialect/databricks.rs +++ b/src/dialect/databricks.rs @@ -65,7 +65,7 @@ impl Dialect for DatabricksDialect { true } - // See https://docs.databricks.com/en/sql/language-manual/sql-ref-syntax-qry-select-groupby.html + /// See https://docs.databricks.com/en/sql/language-manual/sql-ref-syntax-qry-select-groupby.html fn supports_group_by_with_modifier(&self) -> bool { true } From 5e27b31681202cdf2ef48bb54c455c1a3f385022 Mon Sep 17 00:00:00 2001 From: nick young Date: Fri, 26 Sep 2025 08:16:27 -0700 Subject: [PATCH 3/4] Update databricks.rs --- src/dialect/databricks.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dialect/databricks.rs b/src/dialect/databricks.rs index 6c6f269f1..c322a40f5 100644 --- a/src/dialect/databricks.rs +++ b/src/dialect/databricks.rs @@ -64,7 +64,7 @@ impl Dialect for DatabricksDialect { fn supports_struct_literal(&self) -> bool { true } - + /// See fn supports_nested_comments(&self) -> bool { true From 63185b65bf669aa2a1f5194e9df165c0e02bd2bb Mon Sep 17 00:00:00 2001 From: nick young Date: Thu, 2 Oct 2025 00:55:29 -0700 Subject: [PATCH 4/4] Update databricks.rs --- src/dialect/databricks.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dialect/databricks.rs b/src/dialect/databricks.rs index c322a40f5..c5d5f9740 100644 --- a/src/dialect/databricks.rs +++ b/src/dialect/databricks.rs @@ -70,7 +70,7 @@ impl Dialect for DatabricksDialect { true } - /// See https://docs.databricks.com/en/sql/language-manual/sql-ref-syntax-qry-select-groupby.html + /// See fn supports_group_by_with_modifier(&self) -> bool { true }