From 804b1044dc50a2c55ccea2c2ad42193f60bdc30c Mon Sep 17 00:00:00 2001
From: Yoav Cohen <yoav@satoricyber.com>
Date: Thu, 21 May 2026 17:06:37 +0200
Subject: [PATCH] MySQL: Add support for group by with rollup

---
 src/dialect/mysql.rs     | 5 +++++
 tests/sqlparser_mysql.rs | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/src/dialect/mysql.rs b/src/dialect/mysql.rs
index 7c793d0dfa..da92e14113 100644
--- a/src/dialect/mysql.rs
+++ b/src/dialect/mysql.rs
@@ -216,6 +216,11 @@ impl Dialect for MySqlDialect {
     fn supports_key_column_option(&self) -> bool {
         true
     }
+
+    /// See: <https://dev.mysql.com/doc/refman/9.7/en/group-by-modifiers.html>
+    fn supports_group_by_with_modifier(&self) -> bool {
+        true
+    }
 }
 
 /// `LOCK TABLES`
diff --git a/tests/sqlparser_mysql.rs b/tests/sqlparser_mysql.rs
index a511c0dc8d..f513d36700 100644
--- a/tests/sqlparser_mysql.rs
+++ b/tests/sqlparser_mysql.rs
@@ -4900,3 +4900,8 @@ fn parse_adjacent_string_literal_concatenation() {
     let sql = r#"SELECT 'M' "y" 'S' "q" 'l'"#;
     mysql().one_statement_parses_to(sql, r"SELECT 'MySql'");
 }
+
+#[test]
+fn parse_group_by_with_rollup() {
+    mysql().verified_stmt("SELECT * FROM tbl GROUP BY col1, col2 WITH ROLLUP");
+}