Minor code cleanups #245
Merged
Minor code cleanups #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 186371492
💛 - Coveralls |
Dandandan
reviewed
Jul 28, 2020
src/ast/mod.rs
Outdated
| } | ||
| } => write!( | ||
| f, | ||
| "SET{} {} = {}", |
Contributor
There was a problem hiding this comment.
I think it makes sense to use named arguments here {local} etc as well
Contributor
Author
There was a problem hiding this comment.
Right. I was too focussed on the other inconsistencies that I missed how I was introducing another one myself. Thanks for catching that!
Dandandan
approved these changes
Jul 28, 2020
Contributor
|
One small comment which could make it a bit more consistent, looking great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits. @Dandandan would you take a look?