Add negative tests for POSITION #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2219562964
💛 - Coveralls |
yuval-illumex
approved these changes
Apr 25, 2022
Contributor
|
@alamb Thanks! I wanted your feedback on your code before adding tests, so thank you for this PR :) |
Contributor
Author
No problem -- I didn't want to drag out the PR any longer as we had already had several back and forths. If you have more tests in mind, another PR would be great! |
graham
pushed a commit
to graham/sqlparser-rs
that referenced
this pull request
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #463 I noticed the error condition was not covered. Added test coverage here. cc @yuval-illumex