Deferrable column option #470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support in the position function * Add Test * Add lint fixes * Remove if * Change from to in * Remove special method for position * Fix lint * PR Review
graham
force-pushed
the
deferrable-column-option
branch
from
1e64864 to
89804fd
Compare
alamb
reviewed
May 9, 2022
| field: DateTimeField, | ||
| expr: Box<Expr>, | ||
| }, | ||
| /// POSITION(<expr> in <expr>) |
Contributor
There was a problem hiding this comment.
this change appears to be unrelated to DEFERRABLE INITIALLY DEFERRED
I think it was already added in #463
| DialectSpecific(Vec<Token>), | ||
| CharacterSet(ObjectName), | ||
| Comment(String), | ||
| DeferrableInitiallyDeferred, |
Contributor
There was a problem hiding this comment.
Can we add a docstring noting this is from SQLite?
The reference manual https://www.sqlite.org/syntax/foreign-key-clause.html seems to show that it is possible to have NOT INITIALLY DEFERRED as well
What if this was represented with something like
/// SQlite foreign key deferrability
/// https://www.sqlite.org/syntax/foreign-key-clause.html
pub enum DeferType {
Deferred,
Immediate
}
pub enum ColumnOption {
...
/// Sqlite constraint deferrability
/// https://www.sqlite.org/syntax/foreign-key-clause.html
Deferrable {
not: bool,
defer_type: DeferType,
}
...
Contributor
|
Marking this as a draft to show it is waiting some changes so I can easily filter out which PRs need review. Please mark it as "ready for review" when it is next ready. |
Contributor
|
Closing as stale -- please reopen if you still plan to work on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using sqlparser-rs to parse schema from a Django SQLite database I found that deferrable wasn't handled.
Since it exists here: https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#_10_8_constraint_name_definition_and_constraint_characteristics I assume it's reasonable for inclusion.
Happy to make changes to the PR as required, relatively new to rust so I'm well aware I may have style/common practice issues.