-
Notifications
You must be signed in to change notification settings - Fork 670
Deferrable column option #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
28b1f45
add initial support for deferrable
graham 027ad53
test to prove that deferrable parses correctly.
graham c27ca03
Add negative test for IN parsing (#468)
alamb 95fd2c5
Add Support in the "Position" Function (#463)
yuval-illumex 89804fd
Add negative tests for POSITION (#469)
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -291,6 +291,11 @@ pub enum Expr { | |
| field: DateTimeField, | ||
| expr: Box<Expr>, | ||
| }, | ||
| /// POSITION(<expr> in <expr>) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this change appears to be unrelated to I think it was already added in #463 |
||
| Position { | ||
| expr: Box<Expr>, | ||
| r#in: Box<Expr>, | ||
| }, | ||
| /// SUBSTRING(<expr> [FROM <expr>] [FOR <expr>]) | ||
| Substring { | ||
| expr: Box<Expr>, | ||
|
|
@@ -438,6 +443,7 @@ impl fmt::Display for Expr { | |
| Expr::Cast { expr, data_type } => write!(f, "CAST({} AS {})", expr, data_type), | ||
| Expr::TryCast { expr, data_type } => write!(f, "TRY_CAST({} AS {})", expr, data_type), | ||
| Expr::Extract { field, expr } => write!(f, "EXTRACT({} FROM {})", field, expr), | ||
| Expr::Position { expr, r#in } => write!(f, "POSITION({} IN {})", expr, r#in), | ||
| Expr::Collate { expr, collation } => write!(f, "{} COLLATE {}", expr, collation), | ||
| Expr::Nested(ast) => write!(f, "({})", ast), | ||
| Expr::Value(v) => write!(f, "{}", v), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a docstring noting this is from SQLite?
The reference manual https://www.sqlite.org/syntax/foreign-key-clause.html seems to show that it is possible to have
NOT INITIALLY DEFERREDas wellWhat if this was represented with something like