Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ast/ddl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,9 @@ pub enum ColumnOption {
DialectSpecific(Vec<Token>),
CharacterSet(ObjectName),
Comment(String),
DeferrableInitiallyDeferred,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a docstring noting this is from SQLite?

The reference manual https://www.sqlite.org/syntax/foreign-key-clause.html seems to show that it is possible to have NOT INITIALLY DEFERRED as well

What if this was represented with something like

/// SQlite foreign key deferrability
/// https://www.sqlite.org/syntax/foreign-key-clause.html
pub enum DeferType {
  Deferred,
  Immediate
}

pub enum ColumnOption {
...
  /// Sqlite constraint deferrability
  /// https://www.sqlite.org/syntax/foreign-key-clause.html
  Deferrable {
    not: bool,
    defer_type: DeferType,
  }
...

DeferrableInitiallyImmediate,
NotDeferrable,
}

impl fmt::Display for ColumnOption {
Expand Down Expand Up @@ -411,6 +414,9 @@ impl fmt::Display for ColumnOption {
DialectSpecific(val) => write!(f, "{}", display_separated(val, " ")),
CharacterSet(n) => write!(f, "CHARACTER SET {}", n),
Comment(v) => write!(f, "COMMENT '{}'", escape_single_quote_string(v)),
DeferrableInitiallyDeferred => write!(f, "DEFERRABLE INITIALLY DEFERRED"),
DeferrableInitiallyImmediate => write!(f, "DEFERRABLE INITIALLY IMMEDIATE"),
NotDeferrable => write!(f, "NOT DEFERRABLE"),
}
}
}
Expand Down
6 changes: 6 additions & 0 deletions src/ast/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,11 @@ pub enum Expr {
field: DateTimeField,
expr: Box<Expr>,
},
/// POSITION(<expr> in <expr>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change appears to be unrelated to DEFERRABLE INITIALLY DEFERRED

I think it was already added in #463

Position {
expr: Box<Expr>,
r#in: Box<Expr>,
},
/// SUBSTRING(<expr> [FROM <expr>] [FOR <expr>])
Substring {
expr: Box<Expr>,
Expand Down Expand Up @@ -438,6 +443,7 @@ impl fmt::Display for Expr {
Expr::Cast { expr, data_type } => write!(f, "CAST({} AS {})", expr, data_type),
Expr::TryCast { expr, data_type } => write!(f, "TRY_CAST({} AS {})", expr, data_type),
Expr::Extract { field, expr } => write!(f, "EXTRACT({} FROM {})", field, expr),
Expr::Position { expr, r#in } => write!(f, "POSITION({} IN {})", expr, r#in),
Expr::Collate { expr, collation } => write!(f, "{} COLLATE {}", expr, collation),
Expr::Nested(ast) => write!(f, "({})", ast),
Expr::Value(v) => write!(f, "{}", v),
Expand Down
4 changes: 4 additions & 0 deletions src/keywords.rs
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,8 @@ define_keywords!(
DECIMAL,
DECLARE,
DEFAULT,
DEFERRABLE,
DEFERRED,
DELETE,
DELIMITED,
DELIMITER,
Expand Down Expand Up @@ -257,9 +259,11 @@ define_keywords!(
IF,
IGNORE,
ILIKE,
IMMEDIATE,
IN,
INDEX,
INDICATOR,
INITIALLY,
INNER,
INOUT,
INPUTFORMAT,
Expand Down
30 changes: 30 additions & 0 deletions src/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,7 @@ impl<'a> Parser<'a> {
Keyword::TRY_CAST => self.parse_try_cast_expr(),
Keyword::EXISTS => self.parse_exists_expr(),
Keyword::EXTRACT => self.parse_extract_expr(),
Keyword::POSITION => self.parse_position_expr(),
Keyword::SUBSTRING => self.parse_substring_expr(),
Keyword::TRIM => self.parse_trim_expr(),
Keyword::INTERVAL => self.parse_literal_interval(),
Expand Down Expand Up @@ -779,6 +780,24 @@ impl<'a> Parser<'a> {
})
}

pub fn parse_position_expr(&mut self) -> Result<Expr, ParserError> {
// PARSE SELECT POSITION('@' in field)
self.expect_token(&Token::LParen)?;

// Parse the subexpr till the IN keyword
let expr = self.parse_subexpr(Self::BETWEEN_PREC)?;
if self.parse_keyword(Keyword::IN) {
let from = self.parse_expr()?;
self.expect_token(&Token::RParen)?;
Ok(Expr::Position {
expr: Box::new(expr),
r#in: Box::new(from),
})
} else {
return parser_err!("Position function must include IN keyword".to_string());
}
}

pub fn parse_substring_expr(&mut self) -> Result<Expr, ParserError> {
// PARSE SUBSTRING (EXPR [FROM 1] [FOR 3])
self.expect_token(&Token::LParen)?;
Expand Down Expand Up @@ -1975,6 +1994,17 @@ impl<'a> Parser<'a> {
Ok(Some(ColumnOption::Null))
} else if self.parse_keyword(Keyword::DEFAULT) {
Ok(Some(ColumnOption::Default(self.parse_expr()?)))
} else if self.parse_keywords(&[Keyword::NOT, Keyword::DEFERRABLE]) {
Ok(Some(ColumnOption::NotDeferrable))
} else if self.parse_keywords(&[Keyword::DEFERRABLE, Keyword::INITIALLY, Keyword::DEFERRED])
{
Ok(Some(ColumnOption::DeferrableInitiallyDeferred))
} else if self.parse_keywords(&[
Keyword::DEFERRABLE,
Keyword::INITIALLY,
Keyword::IMMEDIATE,
]) {
Ok(Some(ColumnOption::DeferrableInitiallyImmediate))
} else if self.parse_keywords(&[Keyword::PRIMARY, Keyword::KEY]) {
Ok(Some(ColumnOption::Unique { is_primary: true }))
} else if self.parse_keyword(Keyword::UNIQUE) {
Expand Down
83 changes: 83 additions & 0 deletions tests/sqlparser_common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -951,6 +951,17 @@ fn parse_in_unnest() {
chk(true);
}

#[test]
fn parse_in_error() {
// <expr> IN <expr> is no valid
let sql = "SELECT * FROM customers WHERE segment in segment";
let res = parse_sql_statements(sql);
assert_eq!(
ParserError::ParserError("Expected (, found: segment".to_string()),
res.unwrap_err()
);
}

#[test]
fn parse_string_agg() {
let sql = "SELECT a || b";
Expand Down Expand Up @@ -1764,6 +1775,48 @@ fn parse_drop_schema() {
}
}

#[test]
fn parse_deferrable_column_options() {
let sql_deferrable_deferred = r#"
CREATE TABLE test_table (fkey_id INT NOT NULL REFERENCES other_table (id) DEFERRABLE INITIALLY DEFERRED)"#;

match verified_stmt(sql_deferrable_deferred.trim()) {
Statement::CreateTable { columns: c, .. } => {
assert_eq!(
vec![ColumnDef {
name: Ident {
value: "fkey_id".into(),
quote_style: None,
},
data_type: DataType::Int(None),
collation: None,
options: vec![
ColumnOptionDef {
name: None,
option: ColumnOption::NotNull
},
ColumnOptionDef {
name: None,
option: ColumnOption::ForeignKey {
foreign_table: ObjectName(vec!["other_table".into()]),
referred_columns: vec!["id".into()],
on_delete: None,
on_update: None,
}
},
ColumnOptionDef {
name: None,
option: ColumnOption::DeferrableInitiallyDeferred
}
]
}],
c,
);
}
_ => unreachable!(),
}
}

#[test]
fn parse_create_table_as() {
let sql = "CREATE TABLE t AS SELECT * FROM a";
Expand Down Expand Up @@ -4577,3 +4630,33 @@ fn parse_time_functions() {
// Validating Parenthesis
one_statement_parses_to("SELECT CURRENT_DATE", sql);
}

#[test]
fn parse_position() {
let sql = "SELECT POSITION('@' IN field)";
let select = verified_only_select(sql);
assert_eq!(
&Expr::Position {
expr: Box::new(Expr::Value(Value::SingleQuotedString("@".to_string()))),
r#in: Box::new(Expr::Identifier(Ident::new("field"))),
},
expr_from_projection(only(&select.projection))
);
}

#[test]
fn parse_position_negative() {
let sql = "SELECT POSITION(foo) from bar";
let res = parse_sql_statements(sql);
assert_eq!(
ParserError::ParserError("Position function must include IN keyword".to_string()),
res.unwrap_err()
);

let sql = "SELECT POSITION(foo IN) from bar";
let res = parse_sql_statements(sql);
assert_eq!(
ParserError::ParserError("Expected an expression:, found: )".to_string()),
res.unwrap_err()
);
}