-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem or challenge?
Currently, the wildcard expression is defined as Wildcard { qualifier: Option<String> }, and the semantic of the qualifier is unclear. During logical planning, the qualifier string is implicitly parsed via TableReference::from(), which invokes the SQL parser with the generic dialect.
Describe the solution you'd like
It might be a good idea to directly use TableReference as the type for wildcard qualifiers. Doing so will have the following benefits.
- It will make the semantic more clear from the type.
- It will avoid potential bugs when the qualifier is quoted/escaped in a way not supported by the generic SQL dialect.
- It will make
Expr::Wildcardmore consistent with other variants such asExpr::Alias(Alias)(which hasrelation: Option<TableReference>as a field).
Describe alternatives you've considered
N/A
Additional context
N/A
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request