propagate error instead of panicking on out of bounds in physical-expr/src/analysis.rs #10992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorrensP-2158466
changed the title
LorrensP-2158466
changed the title
jonahgao
reviewed
Jun 20, 2024
| let field = schema.fields() | ||
| .get(col_index) | ||
| .ok_or_else(|| DataFusionError::Internal( | ||
| format!("Could not create `ExprBoundaries`: in `try_from_column` `col_index` has gone out of bounds with a value of {col_index}, the schema has {} columns while.", schema.fields.len()) |
Member
There was a problem hiding this comment.
Using internal_datafusion_err could simplify it.
let field = schema.fields().get(col_index).ok_or_else(|| {
internal_datafusion_err!(
"Could not create `ExprBoundaries`: in `try_from_column` `col_index`
has gone out of bounds with a value of {col_index}, the schema has {} columns while.",
schema.fields.len()
)
})?;
Contributor
Author
There was a problem hiding this comment.
Ah yes, that's much more nicer. Thanks!
jonahgao
approved these changes
Jun 20, 2024
Member
jonahgao
left a comment
jonahgao
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @LorrensP-2158466
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jun 22, 2024
…r/src/analysis.rs (apache#10992) * propogate error instead of panicking * use macro for creating internal df error
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jun 22, 2024
…r/src/analysis.rs (apache#10992) * propogate error instead of panicking * use macro for creating internal df error
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…r/src/analysis.rs (apache#10992) * propogate error instead of panicking * use macro for creating internal df error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10536.
Rationale for this change
In
datafusion/datafusion/physical-expr/src/analysis.rs
Line 95 in cafbc9d
The function panics when
col_indexis out of bounds when returning an internal error with extra context is much more convenient.What changes are included in this PR?
Propagate the error as en
DataFusionError::Internal.Are these changes tested?
Are there any user-facing changes?
Users may need to handle that error case