decimal support for unparser #11092
Merged
decimal support for unparser #11092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipleblanc
approved these changes
Jun 24, 2024
Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
alamb
approved these changes
Jun 24, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @y-f-u and @phillipleblanc for the review
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* decimal support for unparser * Update datafusion/sql/src/unparser/expr.rs Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> * cargo fmt --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Basic support for decimal unparsing
Rationale for this change
Decimal is a common type in many sql engines, custom data provider will need this when query involves decimal
What changes are included in this PR?
Convert decimal 128 and 256 to Ast type.
Convert both of them into string.
Are these changes tested?
Yes
Are there any user-facing changes?
No