Fix running in Docker instructions #11141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
commented
Jun 27, 2024
| ```bash | ||
| git clone https://github.com/apache/datafusion | ||
| cd arrow-datafusion | ||
| git checkout 12.0.0 |
Member
Author
There was a problem hiding this comment.
When i tried to check out 12.0.0. tag, the docker build command failed with some unsatisfied dependencies.
| git checkout 12.0.0 | ||
| cd datafusion | ||
| docker build -f datafusion-cli/Dockerfile . --tag datafusion-cli | ||
| docker run -it -v $(your_data_location):/data datafusion-cli |
Member
Author
There was a problem hiding this comment.
I'd propose to add --rm here and take out -v $(your_data_location):/data.
this would result in the command being directly copy-pastable into terminal without modifications and also would reduce side effects.
Contributor
There was a problem hiding this comment.
Maybe we could add a comment like
# Run with data mounted at /data in the container
# docker run --rm -it -v $(your_data_location):/data datafusion-cli
# Run in a container without access to the host filesystem
docker run --rm -it datafusion-cli
Contributor
There was a problem hiding this comment.
🤔 though the second command doesn't work
andrewlamb@Andrews-MacBook-Pro-2 datafusion % docker run --rm -it datafusion-cli
error: Invalid value "/data" for '--data-path <DATA_PATH>': Invalid data directory '/data'
alamb
approved these changes
Jun 27, 2024
| git checkout 12.0.0 | ||
| cd datafusion | ||
| docker build -f datafusion-cli/Dockerfile . --tag datafusion-cli | ||
| docker run -it -v $(your_data_location):/data datafusion-cli |
Contributor
There was a problem hiding this comment.
Maybe we could add a comment like
# Run with data mounted at /data in the container
# docker run --rm -it -v $(your_data_location):/data datafusion-cli
# Run in a container without access to the host filesystem
docker run --rm -it datafusion-cli| git checkout 12.0.0 | ||
| cd datafusion | ||
| docker build -f datafusion-cli/Dockerfile . --tag datafusion-cli | ||
| docker run -it -v $(your_data_location):/data datafusion-cli |
Contributor
There was a problem hiding this comment.
🤔 though the second command doesn't work
andrewlamb@Andrews-MacBook-Pro-2 datafusion % docker run --rm -it datafusion-cli
error: Invalid value "/data" for '--data-path <DATA_PATH>': Invalid data directory '/data'
Member
Author
findepi
added a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.