Skip to content

Fix running in Docker instructions #11141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix running in Docker instructions #11141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/source/user-guide/cli/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ this to work.

```bash
git clone https://github.com/apache/datafusion
cd arrow-datafusion
git checkout 12.0.0
Copy link
Member Author

@findepi findepi Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i tried to check out 12.0.0. tag, the docker build command failed with some unsatisfied dependencies.

cd datafusion
docker build -f datafusion-cli/Dockerfile . --tag datafusion-cli
docker run -it -v $(your_data_location):/data datafusion-cli
Copy link
Member Author

@findepi findepi Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose to add --rm here and take out -v $(your_data_location):/data.
this would result in the command being directly copy-pastable into terminal without modifications and also would reduce side effects.

Copy link
Contributor

@alamb alamb Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add a comment like

# Run with data mounted at /data in the container
# docker run --rm -it -v $(your_data_location):/data datafusion-cli

# Run in a container without access to the host filesystem
docker run --rm -it  datafusion-cli

Copy link
Contributor

@alamb alamb Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 though the second command doesn't work

andrewlamb@Andrews-MacBook-Pro-2 datafusion % docker run --rm -it  datafusion-cli
error: Invalid value "/data" for '--data-path <DATA_PATH>': Invalid data directory '/data'

```