fix: Support dictionary type in parquet metadata statistics. #11169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appletreeisyellow
approved these changes
Jun 28, 2024
Contributor
appletreeisyellow
left a comment
appletreeisyellow
left a comment
There was a problem hiding this comment.
Thank you for fixing it! @efredine 💯
I left comments in the test to avoid confusions
| assert_eq!(c_dic_stats.null_count, Precision::Exact(0)); | ||
| assert_eq!( | ||
| c_dic_stats.max_value, | ||
| Precision::Exact(Utf8(Some("c".into()))) |
Contributor
There was a problem hiding this comment.
Suggested change
| Precision::Exact(Utf8(Some("c".into()))) | |
| Precision::Exact(Utf8(Some("d".into()))) |
To avoid any confusion, with the new dictionary keys, the max value is "d"
Contributor
Author
|
Thanks @alamb @appletreeisyellow - I should have reviewed the tests more closely - thanks for the feedback. I will make the adjustments now. |
alamb
approved these changes
Jun 30, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks again @efredine and @appletreeisyellow
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…11169) * fix: Support dictionary type in parquet metadata statistics. * Simplify tests. --------- Co-authored-by: Eric Fredine <eric.fredine@beanworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11145.
Rationale for this change
What changes are included in this PR?
Modifies
create_max_min_accsto instantiate accumulators for unpacked data - the value DataType of the Dictionary.This bug is very similar to a previous bug that impacted the Min/Max aggregate functions. #1235
In addition, the
min_max_aggregate_data_typefn is copied fromdatafusion/datafusion/physical-expr/src/aggregate/min_max.rs
Lines 63 to 73 in 8216e32
I'm unsure if copying the function is the right thing to do in order to prevent coupling between the crates or if it should be moved to some core crate? It also seems like the dedicated min and max functions are to be refactored into a user defined functions?
Are these changes tested?
Yes - a new test has been added.
Are there any user-facing changes?
Currently implemented so the column statistics are returned as an unpacked type. So for
DataType::Dictionary(Int32, Utf8)the min or max value is returned asExact(Utf8("a")). Would it be better to return it asExact(Dictionary(Int32, Utf8("a")))? I'm unsure what the previous implementation would have returned and whether or not it was correct. But it's possible that returning it as an unpacked type would be a breaking change if it previously returned it as a Dictionary type.Happy to change the implementation to return a Dictionary type. I'm just unsure which offers the best experience.