HashJoin can preserve the right ordering when join type is Right #11276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozankabak
approved these changes
Jul 5, 2024
Contributor
There was a problem hiding this comment.
LGTM, thank you.
Edit: After discussing with @mustafasrepo and @berkaysynnada, I think we can add one more small optimization to append_right_indices to leverage existing probe side ordering via merging. We will send another commit to incorporate that in this PR as well
ozankabak
approved these changes
Jul 5, 2024
Contributor
ozankabak
left a comment
ozankabak
left a comment
There was a problem hiding this comment.
We added the mini optimization and this PR is ready from my perspective. Let's wait a couple days in case anyone wants to check it out and suggest improvements
Contributor
Dandandan
approved these changes
Jul 7, 2024
viirya
reviewed
Jul 7, 2024
viirya
approved these changes
Jul 7, 2024
viirya
reviewed
Jul 7, 2024
viirya
reviewed
Jul 7, 2024
viirya
reviewed
Jul 7, 2024
viirya
reviewed
Jul 7, 2024
viirya
reviewed
Jul 7, 2024
viirya
reviewed
Jul 7, 2024
viirya
reviewed
Jul 7, 2024
korowa
reviewed
Jul 7, 2024
ozankabak
reviewed
Jul 7, 2024
Contributor
|
Seems like we have incorporated all the feedback. I will merge this later on today unless we get more feedback for improvements. Thanks everyone |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…che#11276) * Preserve right hash order * Update joins.slt * better sorting alg * remove result * Review * add plan test * Address review feedback * Expand test coverage and update docstring --------- Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
…che#11276) * Preserve right hash order * Update joins.slt * better sorting alg * remove result * Review * add plan test * Address review feedback * Expand test coverage and update docstring --------- Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
HashJoins can preserve the order of the right input when the join type is right.
What changes are included in this PR?
HashJoinandNestedLoopJoinusesappend_right_indices()method to combine matched and unmatched right results. This method simply appends the unmatched ones on matched ones. However, if we know that right is ordered, we can merge these indices in order to preserve order.Are these changes tested?
Yes, with an .slt test. Added test would result as:
before, which breaks the order.
Are there any user-facing changes?