Minor: Add ConstExpr::from and use in physical optimizer
#11283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
commented
Jul 5, 2024
| }); | ||
| let constants = constants | ||
| .into_iter() | ||
| .map(|expr| ConstExpr::from(expr).with_across_partitions(true)); |
Contributor
Author
There was a problem hiding this comment.
I think this change makes it easier to follow the logic here
mustafasrepo
approved these changes
Jul 6, 2024
Contributor
mustafasrepo
left a comment
mustafasrepo
left a comment
There was a problem hiding this comment.
LGTM! Thanks @alamb.
Contributor
Author
|
Thank you for the review @mustafasrepo |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #11240
Rationale for this change
Some of the code manipulating
ConstExprwas getting unweidly especially afterArc::cloneis requiredWhat changes are included in this PR?
ConstExpr::from(..)to make creatingConstExprmore conciseAre these changes tested?
Existing CI
Are there any user-facing changes?