Minor: use lit(true) and lit(false) more
#11904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
force-pushed
the
alamb/lit_cleanup
branch
from
8fee876 to
aadfe11
Compare
lewiszlw
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
While looking at #11897 from @Lordworms I noticed several places where the very long form of creating a literal boolean was used:
I would like to encourage people to use the shorter form:
Which both makes the code shorter and easier to read
What changes are included in this PR?
Replace some
Expr::Literal(ScalarValue::Boolean(Some(false)))withlit(false)Expr::Literal(ScalarValue::Boolean(Some(true)))withlit(true)Are these changes tested?
By CI
Are there any user-facing changes?
No, this is all internal only