diff --git a/dev/release/README.md b/dev/release/README.md index 5b51295efdd8..d70e256f7383 100644 --- a/dev/release/README.md +++ b/dev/release/README.md @@ -311,47 +311,8 @@ Verify that the Cargo.toml in the tarball contains the correct version ### Publish datafusion-cli on Homebrew -Run `publish_homebrew.sh` to publish `datafusion-cli` on Homebrew. In order to do so it is necessary to -fork the `homebrew-core` repo https://github.com/Homebrew/homebrew-core/, have Homebrew installed on your -macOS/Linux/WSL2 and properly configured and have a Github Personal Access Token that has permission to file pull requests in the `homebrew-core` repo. - -#### Fork the `homebrew-core` repo - -Go to https://github.com/Homebrew/homebrew-core/ and fork the repo. - -#### Install and configure Homebrew - -Please visit https://brew.sh/ to obtain Homebrew. In addition to that please check out https://docs.brew.sh/Homebrew-on-Linux if you are on Linux or WSL2. - -Before running the script make sure that you can run the following command in your bash to make sure -that `brew` has been installed and configured properly: - -```shell -brew --version -``` - -#### Create a Github Personal Access Token - -To create a Github Personal Access Token, please visit https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token for instructions. - -- Make sure to select either **All repositories** or **Only selected repositories** so that you have access to **Repository permissions**. -- If you only use the token for selected repos make sure you include your - fork of `homebrew-core` in the list of repos under **Selected repositories**. -- Make sure to have **Read and write** access enabled for pull requests in your **Repository permissions**. - -After all of the above is complete execute the following command: - -```shell -dev/release/publish_homebrew.sh -``` - -Note that sometimes someone else has already submitted a PR to update the datafusion formula in homebrew. -In this case you will get an error with a message that your PR is a duplicate of an existing one. In this -case no further action is required. - -Alternatively manually submit a simple PR to update tag and commit hash for the datafusion -formula in homebrew-core. Here is an example PR: -https://github.com/Homebrew/homebrew-core/pull/89562. +[`datafusion` formula](https://formulae.brew.sh/formula/datafusion) is [updated automatically](https://github.com/Homebrew/homebrew-core/pulls?q=is%3Apr+datafusion+is%3Aclosed), +so no action is needed. ### Call the vote diff --git a/dev/release/publish_homebrew.sh b/dev/release/publish_homebrew.sh deleted file mode 100644 index 20955953e85a..000000000000 --- a/dev/release/publish_homebrew.sh +++ /dev/null @@ -1,92 +0,0 @@ -#!/usr/bin/env bash -# -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -set -ue - -if [ "$#" -ne 4 ]; then - echo "Usage: $0 " - exit 1 -fi - -version=$1 -github_user=$2 -github_token=$3 -# Prepare for possible renaming of the default branch on Homebrew -homebrew_default_branch_name=$4 - -# Git parallel fetch -if sysctl -n hw.ncpu 2>/dev/null; then # macOS - num_processing_units=$(sysctl -n hw.ncpu) -elif [ -x "$(command -v nproc)" ]; then # Linux - num_processing_units=$(nproc) -else # Fallback - num_processing_units=1 -fi - -url="https://www.apache.org/dyn/closer.lua?path=datafusion/datafusion-${version}/apache-datafusion-${version}.tar.gz" -sha256="$(curl https://dist.apache.org/repos/dist/release/datafusion/datafusion-${version}/apache-datafusion-${version}.tar.gz.sha256 | cut -d' ' -f1)" - -pushd "$(brew --repository homebrew/core)" - -if ! git remote | grep -q --fixed-strings ${github_user}; then - echo "Setting ''${github_user}' remote" - git remote add ${github_user} git@github.com:${github_user}/homebrew-core.git -fi - -echo "Updating working copy" -git fetch --all --prune --tags --force -j$num_processing_units - -branch=apache-datafusion-${version} -echo "Creating branch: ${branch}" -git branch -D ${branch} || : -git checkout -b ${branch} origin/master - -echo "Updating datafusion formulae" -brew bump-formula-pr \ - --commit \ - --no-audit \ - --sha256="${sha256}" \ - --url="${url}" \ - --verbose \ - --write-only \ - datafusion - -echo "Testing datafusion formulae" -brew uninstall datafusion || : -brew install --build-from-source datafusion -brew test datafusion -brew audit --strict datafusion - -git push -u $github_user ${branch} - -git checkout - - -popd - -echo "Create the pull request" -title="datafusion ${version}" -body="Created using \`bump-formula-pr\`" -data="{\"title\":\"$title\", \"body\":\"$body\", \"head\":\"$github_username:$branch\", \"base\":\"$homebrew_default_branch_name\"}" -curl -X POST \ - -H "Accept: application/vnd.github+json" \ - -H "Authorization: Bearer $github_token" \ - https://api.github.com/repos/Homebrew/homebrew-core/pulls \ - -d "$data" - -echo "Complete!"