From e309b5fb4e53dece92e6aa8e08680fdd644466d9 Mon Sep 17 00:00:00 2001 From: foskey51 Date: Sun, 16 Nov 2025 04:19:25 +0000 Subject: [PATCH] chore: enforce clippy lint needless_pass_by_value to datafusion-functions-aggregate-common --- datafusion/functions-aggregate-common/src/lib.rs | 3 +++ datafusion/functions-aggregate-common/src/tdigest.rs | 1 + 2 files changed, 4 insertions(+) diff --git a/datafusion/functions-aggregate-common/src/lib.rs b/datafusion/functions-aggregate-common/src/lib.rs index 7449cf72cfb8..468836f3ab4e 100644 --- a/datafusion/functions-aggregate-common/src/lib.rs +++ b/datafusion/functions-aggregate-common/src/lib.rs @@ -30,6 +30,9 @@ // Make sure fast / cheap clones on Arc are explicit: // https://github.com/apache/datafusion/issues/11143 #![deny(clippy::clone_on_ref_ptr)] +// https://github.com/apache/datafusion/issues/18503 +#![deny(clippy::needless_pass_by_value)] +#![cfg_attr(test, allow(clippy::needless_pass_by_value))] pub mod accumulator; pub mod aggregate; diff --git a/datafusion/functions-aggregate-common/src/tdigest.rs b/datafusion/functions-aggregate-common/src/tdigest.rs index 320157fb7bd8..39bbf5a32092 100644 --- a/datafusion/functions-aggregate-common/src/tdigest.rs +++ b/datafusion/functions-aggregate-common/src/tdigest.rs @@ -163,6 +163,7 @@ impl TDigest { } } + #[expect(clippy::needless_pass_by_value)] pub fn new_with_centroid(max_size: usize, centroid: Centroid) -> Self { TDigest { centroids: vec![centroid.clone()],