chore: enforce clippy::allow_attributes for physical crates

[carlosahs]

Which issue does this PR close?

• Part of New lint clippy::allow_attributes #18881.

Rationale for this change

Please refer to #18881.

What changes are included in this PR?

• Added #![deny(clippy::allow_attributes)] to the following crates:

  • datafusion-physical-expr-adapter.
  • datafusion-physical-expr-common.
  • datafusion-physical-optimizer.

• Removed #[allow(deprecated)] from

  datafusion/datafusion/physical-optimizer/src/filter_pushdown.rs

  Lines 432 to 443 in cb2f3d2

  	#[allow(deprecated)]
  	fn optimize(
  	&self,
  	plan: Arc<dyn ExecutionPlan>,
  	config: &ConfigOptions,
  	) -> Result<Arc<dyn ExecutionPlan>> {
  	Ok(
  	push_down_filters(&Arc::clone(&plan), vec![], config, self.phase)?
  	.updated_node
  	.unwrap_or(plan),
  	)
  	}

  as lint is only fulfilled on usage of #[deprecated] items, thus when #[expect(deprecated)] is used instead of #[allow(deprecated)] it results in error: this lint expectation is unfulfilled.

• Kept #[allow(clippy::only_used_in_recursion)] in

  datafusion/datafusion/physical-optimizer/src/aggregate_statistics.rs

  Lines 43 to 98 in 6746007

  	#[cfg_attr(feature = "recursive_protection", recursive::recursive)]
  	#[allow(clippy::only_used_in_recursion)] // See https://github.com/rust-lang/rust-clippy/issues/14566
  	fn optimize_plan(
  	&self,
  	plan: Arc<dyn ExecutionPlan>,
  	context: &OptimizerContext,
  	) -> Result<Arc<dyn ExecutionPlan>> {
  	if let Some(partial_agg_exec) = take_optimizable(&*plan) {
  	let partial_agg_exec = partial_agg_exec
  	.as_any()
  	.downcast_ref::<AggregateExec>()
  	.expect("take_optimizable() ensures that this is a AggregateExec");
  	let stats = partial_agg_exec.input().partition_statistics(None)?;
  	let mut projections = vec![];
  	for expr in partial_agg_exec.aggr_expr() {
  	let field = expr.field();
  	let args = expr.expressions();
  	let statistics_args = StatisticsArgs {
  	statistics: &stats,
  	return_type: field.data_type(),
  	is_distinct: expr.is_distinct(),
  	exprs: args.as_slice(),
  	};
  	if let Some((optimizable_statistic, name)) =
  	take_optimizable_value_from_statistics(&statistics_args, expr)
  	{
  	projections.push(ProjectionExpr {
  	expr: expressions::lit(optimizable_statistic),
  	alias: name.to_owned(),
  	});
  	} else {
  	// TODO: we need all aggr_expr to be resolved (cf TODO fullres)
  	break;
  	}
  	}
  	// TODO fullres: use statistics even if not all aggr_expr could be resolved
  	if projections.len() == partial_agg_exec.aggr_expr().len() {
  	// input can be entirely removed
  	Ok(Arc::new(ProjectionExec::try_new(
  	projections,
  	Arc::new(PlaceholderRowExec::new(plan.schema())),
  	)?))
  	} else {
  	plan.map_children(|child| {
  	self.optimize_plan(child, context).map(Transformed::yes)
  	})
  	.data()
  	}
  	} else {
  	plan.map_children(|child| {
  	self.optimize_plan(child, context).map(Transformed::yes)
  	})
  	.data()
  	}
  	}

  as #[expect(clippy::only_used_in_recursion)] resulted in error: this lint expectation is unfulfilled when running sh ci/scripts/rust_clippy.sh but was successful when running cargo clippy -p datafusion-physical-optimizer -- -D warning. Ref: New lint clippy::allow_attributes #18881 (comment).

  For now, easiest solution is to locally expect #[expect(clippy::allow_attributes)].

Are these changes tested?

Successfully ran sh ci/scripts/rust_clippy.sh.

Are there any user-facing changes?

No.

[Jefffrey]

Thanks @carlosahs