fix(concat): correct nullability inference (nullable only if all arguments nullable) #19189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19171
Problem
The
concatscalar function currently reports its result as always nullable atplanning/schema time. However, its runtime semantics are:
concatignores NULL inputs.This mismatch causes incorrect nullability in inferred schemas and can affect
optimizer behavior.
What this PR does
Implements
return_field_from_argsforConcatFuncso that:DataTypeis derived using the existingreturn_typelogic.(If there are no argument fields, the return is considered nullable defensively.)
This aligns schema-time nullability with runtime behavior and matches the
semantics used by other SQL engines.
Tests
concatpass.Notes
If CI finds any compatibility adjustments required across DataFusion crates,
I will update this PR accordingly.