From 5c23b4df894ba3ffb438e4010f050ade95ad75b1 Mon Sep 17 00:00:00 2001 From: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Date: Tue, 26 May 2026 00:47:57 -0700 Subject: [PATCH] chore: fix two comment typos - datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs L737: scalarized_intern_remaining doc said "preform" -> "perform" - datafusion/core/tests/dataframe/mod.rs L843: comment said "functionally dependant" -> "functionally dependent" Comment-only. --- datafusion/core/tests/dataframe/mod.rs | 6 +++--- .../src/aggregates/group_values/multi_group_by/mod.rs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/datafusion/core/tests/dataframe/mod.rs b/datafusion/core/tests/dataframe/mod.rs index 19d5ecb842297..6512d9b432597 100644 --- a/datafusion/core/tests/dataframe/mod.rs +++ b/datafusion/core/tests/dataframe/mod.rs @@ -840,7 +840,7 @@ async fn test_aggregate_with_pk() -> Result<()> { let aggr_expr = vec![]; let df = df.aggregate(group_expr, aggr_expr)?; - // Since id and name are functionally dependant, we can use name among + // Since id and name are functionally dependent, we can use name among // expression even if it is not part of the group by expression and can // select "name" column even though it wasn't explicitly grouped let df = df.select(vec![col("id"), col("name")])?; @@ -895,7 +895,7 @@ async fn test_aggregate_with_pk2() -> Result<()> { " ); - // Since id and name are functionally dependant, we can use name among expression + // Since id and name are functionally dependent, we can use name among expression // even if it is not part of the group by expression. let df_results = df.collect().await?; @@ -943,7 +943,7 @@ async fn test_aggregate_with_pk3() -> Result<()> { " ); - // Since id and name are functionally dependant, we can use name among expression + // Since id and name are functionally dependent, we can use name among expression // even if it is not part of the group by expression. let df_results = df.collect().await?; diff --git a/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs b/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs index 12d80b1f9bad1..cf2d4f49aea43 100644 --- a/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs +++ b/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs @@ -734,7 +734,7 @@ impl GroupValuesColumn { /// /// The hash collision may be not frequent, so the fallback will indeed hardly happen. /// In most situations, `scalarized_indices` will found to be empty after finishing to - /// preform `vectorized_equal_to`. + /// perform `vectorized_equal_to`. fn scalarized_intern_remaining( &mut self, cols: &[ArrayRef],