From 41d1d88078003c8c5541533668670f88b39f097c Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Wed, 27 May 2026 18:04:18 +0300 Subject: [PATCH 1/5] trigger breaking change --- datafusion/core/src/lib.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/datafusion/core/src/lib.rs b/datafusion/core/src/lib.rs index 3170f4be7f683..e17d210c392d4 100644 --- a/datafusion/core/src/lib.rs +++ b/datafusion/core/src/lib.rs @@ -804,9 +804,6 @@ pub mod common { } } -// Backwards compatibility -pub use common::config; - // NB datafusion execution is re-exported in the `execution` module /// re-export of [`datafusion_catalog`] crate From 20a4cdb93619329004deb9eeddd09270b3c37fc5 Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Wed, 27 May 2026 18:06:12 +0300 Subject: [PATCH 2/5] remove breaking change detector comment and replace with log to see if it is working --- .../breaking_changes_detector_comment.yml | 97 +------------------ 1 file changed, 5 insertions(+), 92 deletions(-) diff --git a/.github/workflows/breaking_changes_detector_comment.yml b/.github/workflows/breaking_changes_detector_comment.yml index 579c61cb9d5c7..55f71cb105cf5 100644 --- a/.github/workflows/breaking_changes_detector_comment.yml +++ b/.github/workflows/breaking_changes_detector_comment.yml @@ -65,96 +65,9 @@ jobs: # Scoped to the minimum needed to upsert/delete the sticky comment. permissions: actions: read - pull-requests: write - steps: - - name: Download semver-check artifact - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 - with: - name: semver-check-result - run-id: ${{ github.event.workflow_run.id }} - github-token: ${{ github.token }} - path: ./semver-artifact - - - name: Read and validate artifact - id: read - run: | - set -euo pipefail - # Validate every field: the artifact comes from a workflow run - # that compiled fork-controlled code, so its contents are untrusted. - PR_NUMBER=$(cat ./semver-artifact/pr_number) - if ! [[ "$PR_NUMBER" =~ ^[0-9]+$ ]]; then - echo "Invalid PR number: $PR_NUMBER" >&2 - exit 1 - fi - CHECK_RESULT=$(cat ./semver-artifact/result) - if [[ "$CHECK_RESULT" != "success" && "$CHECK_RESULT" != "failure" ]]; then - echo "Invalid check result: $CHECK_RESULT" >&2 - exit 1 - fi - echo "pr_number=$PR_NUMBER" >> "$GITHUB_OUTPUT" - echo "result=$CHECK_RESULT" >> "$GITHUB_OUTPUT" - - # Multi-line output: random delimiter so a malicious log line can't - # close the heredoc and inject extra output keys. See: - # https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#multiline-strings - DELIM="EOF_$(openssl rand -hex 16)" - { - echo "logs<<${DELIM}" - cat ./semver-artifact/logs - echo "${DELIM}" - } >> "$GITHUB_OUTPUT" - - # The marker `` is what makes the comment - # "sticky": maintain-one-comment uses it to find and replace (or - # delete) the existing comment instead of stacking new ones. - - name: Upsert sticky comment - if: steps.read.outputs.result != 'success' - uses: actions-cool/maintain-one-comment@909842216bc8e8658364c572ec52100f4c2cc50a # v3.3.0 - with: - token: ${{ secrets.GITHUB_TOKEN }} - number: ${{ steps.read.outputs.pr_number }} - body-include: '' - body: | - - Thank you for opening this pull request! - - Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). - -
- Details + pull-requests: read - ``` - ${{ steps.read.outputs.logs }} - ``` - -
- - - name: Delete sticky comment - if: steps.read.outputs.result == 'success' - uses: actions-cool/maintain-one-comment@909842216bc8e8658364c572ec52100f4c2cc50a # v3.3.0 - with: - token: ${{ secrets.GITHUB_TOKEN }} - number: ${{ steps.read.outputs.pr_number }} - body-include: '' - delete: true - - - name: Add "auto detected api change" label - if: steps.read.outputs.result != 'success' - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - REPO: ${{ github.repository }} - PR_NUMBER: ${{ steps.read.outputs.pr_number }} - run: | - gh pr edit "$PR_NUMBER" --repo "$REPO" \ - --add-label "$BREAKING_CHANGE_LABEL" - - - name: Remove "auto detected api change" label - if: steps.read.outputs.result == 'success' - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - REPO: ${{ github.repository }} - PR_NUMBER: ${{ steps.read.outputs.pr_number }} - run: | - # No-op when the label isn't currently applied. - gh pr edit "$PR_NUMBER" --repo "$REPO" \ - --remove-label "$BREAKING_CHANGE_LABEL" || true + # Check if working at all + steps: + - name: echo + run: echo "HELLLO" From 9127ad77718e1495703e825d7505bfb79438656d Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Wed, 27 May 2026 18:24:42 +0300 Subject: [PATCH 3/5] make breaking change in the crate with no workspace deps for faster ci time --- datafusion/common/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/common/src/lib.rs b/datafusion/common/src/lib.rs index e865c548bb554..ab2f65da8ea6c 100644 --- a/datafusion/common/src/lib.rs +++ b/datafusion/common/src/lib.rs @@ -98,7 +98,7 @@ pub use spans::{Location, Span, Spans}; pub use stats::{ColumnStatistics, Statistics}; pub use table_reference::{ResolvedTableReference, TableReference}; pub use unnest::{RecursionUnnestOption, UnnestOptions}; -pub use utils::project_schema; +// pub use utils::project_schema; // These are hidden from docs purely to avoid polluting the public view of what this crate exports. // These are just re-exports of macros by the same name, which gets around the 'cannot refer to From 7af51b47167c6d26432f1f983666a46ac6200247 Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Wed, 27 May 2026 18:25:59 +0300 Subject: [PATCH 4/5] revert --- datafusion/core/src/lib.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/datafusion/core/src/lib.rs b/datafusion/core/src/lib.rs index e17d210c392d4..3170f4be7f683 100644 --- a/datafusion/core/src/lib.rs +++ b/datafusion/core/src/lib.rs @@ -804,6 +804,9 @@ pub mod common { } } +// Backwards compatibility +pub use common::config; + // NB datafusion execution is re-exported in the `execution` module /// re-export of [`datafusion_catalog`] crate From f5f573533d5b31dc798c226bb881172a156a4b1d Mon Sep 17 00:00:00 2001 From: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Wed, 27 May 2026 19:48:45 +0300 Subject: [PATCH 5/5] allow not running only on main Comment out the branches section in pull_request trigger. --- .github/workflows/breaking_changes_detector.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/breaking_changes_detector.yml b/.github/workflows/breaking_changes_detector.yml index daee0ac067d18..dc5896aae2d86 100644 --- a/.github/workflows/breaking_changes_detector.yml +++ b/.github/workflows/breaking_changes_detector.yml @@ -43,8 +43,8 @@ name: "Detect breaking changes" on: pull_request: - branches: - - main + # branches: + # - main permissions: contents: read