Skip to content

Conversation

@tustvold
Copy link
Contributor

@github-actions github-actions bot added the core Core DataFusion crate label Jul 18, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, the idea is to hint to users that they should use Arc<ObjectStoreRegistry>?

cc @yahoNanJing

@alamb alamb changed the title Remove ObjectStoreRegistry::clone Use Arc<ObjectStoreRegistry> and remove ObjectStoreRegistry::clone Jul 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2941 (bc62474) into master (305e265) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2941      +/-   ##
==========================================
+ Coverage   85.32%   85.39%   +0.07%     
==========================================
  Files         273      273              
  Lines       49498    49441      -57     
==========================================
- Hits        42235    42221      -14     
+ Misses       7263     7220      -43     
Impacted Files Coverage Δ
datafusion/core/src/datasource/object_store.rs 84.44% <100.00%> (ø)
datafusion/core/src/execution/runtime_env.rs 75.00% <100.00%> (ø)
datafusion/proto/src/to_proto.rs 53.40% <0.00%> (-3.07%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 76.78% <0.00%> (-0.36%) ⬇️
...atafusion/physical-expr/src/aggregate/array_agg.rs 95.87% <0.00%> (-0.05%) ⬇️
...sion/physical-expr/src/aggregate/count_distinct.rs 95.03% <0.00%> (+0.01%) ⬆️
datafusion/physical-expr/src/aggregate/tdigest.rs 91.30% <0.00%> (+0.05%) ⬆️
datafusion/common/src/scalar.rs 84.81% <0.00%> (+0.06%) ⬆️
...fusion/physical-expr/src/aggregate/sum_distinct.rs 92.72% <0.00%> (+0.06%) ⬆️
datafusion/proto/src/lib.rs 93.47% <0.00%> (+0.15%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305e265...bc62474. Read the comment docs.

@tustvold tustvold merged commit a2be1dc into apache:master Jul 18, 2022
@ursabot
Copy link

ursabot commented Jul 18, 2022

Benchmark runs are scheduled for baseline = 9414a74 and contender = a2be1dc. a2be1dc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants