-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add json print format mode to datafusion cli #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 76.08% 76.19% +0.11%
==========================================
Files 141 141
Lines 23734 23786 +52
==========================================
+ Hits 18057 18123 +66
+ Misses 5677 5663 -14
Continue to review full report at Codecov.
|
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- thanks @jimexist
|
|
||
| let batches = vec![batch]; | ||
| let r = print_batches_to_json(&batches).unwrap(); | ||
| assert_eq!("[{\"a\":1,\"b\":4,\"c\":7},{\"a\":2,\"b\":5,\"c\":8},{\"a\":3,\"b\":6,\"c\":9}]", r); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 for the tests
Which issue does this PR close?
Closes #294
should be merged after #290 and #292
Rationale for this change
So far we have csv table tsv, we can easily add json support
What changes are included in this PR?
add json support
Are there any user-facing changes?
no breaking changes, just new feature