From 3f37a18d99311355f23c90b624babff87a58142b Mon Sep 17 00:00:00 2001 From: Jiayu Liu Date: Sun, 9 May 2021 14:13:33 +0800 Subject: [PATCH 1/2] allow datafusion cli to take -- comments --- datafusion-cli/src/main.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/datafusion-cli/src/main.rs b/datafusion-cli/src/main.rs index 05c6766cee72..19947d4bc9dd 100644 --- a/datafusion-cli/src/main.rs +++ b/datafusion-cli/src/main.rs @@ -114,6 +114,9 @@ async fn exec_from_lines( for line in reader.lines() { match line { + Ok(line) if line.starts_with("--") => { + continue; + } Ok(line) => { let line = line.trim_end(); query.push_str(line); @@ -154,6 +157,9 @@ async fn exec_from_repl(execution_config: ExecutionConfig, print_format: PrintFo Ok(ref line) if is_exit_command(line) && query.is_empty() => { break; } + Ok(ref line) if line.starts_with("--") => { + continue; + } Ok(ref line) if line.trim_end().ends_with(';') => { query.push_str(line.trim_end()); rl.add_history_entry(query.clone()); From 5e1b074be9f22ad522216565ed2486cdd261dc52 Mon Sep 17 00:00:00 2001 From: Jiayu Liu Date: Sun, 9 May 2021 23:06:04 +0800 Subject: [PATCH 2/2] append \n not _ --- datafusion-cli/src/main.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datafusion-cli/src/main.rs b/datafusion-cli/src/main.rs index 19947d4bc9dd..f15c1d8e4a21 100644 --- a/datafusion-cli/src/main.rs +++ b/datafusion-cli/src/main.rs @@ -127,7 +127,7 @@ async fn exec_from_lines( } query = "".to_owned(); } else { - query.push(' '); + query.push('\n'); } } _ => { @@ -171,7 +171,7 @@ async fn exec_from_repl(execution_config: ExecutionConfig, print_format: PrintFo } Ok(ref line) => { query.push_str(line); - query.push(' '); + query.push('\n'); } Err(_) => { break;