-
Notifications
You must be signed in to change notification settings - Fork 1.8k
minor: collation the prune test #2986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: collation the prune test #2986
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2986 +/- ##
==========================================
- Coverage 85.78% 85.77% -0.01%
==========================================
Files 281 281
Lines 51580 51526 -54
==========================================
- Hits 44246 44197 -49
+ Misses 7334 7329 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @liukun4515 this looks great
| .query_with_expr(col("date64").lt(lit(date))) | ||
| // .query( | ||
| // "SELECT * FROM t where date64 < caste('2020-01-02' as date)", | ||
| // "SELECT * FROM t where date64 < cast('2020-01-02' as date)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| assert_eq!(output.predicate_evaluation_errors(), Some(0)); | ||
| assert_eq!(output.row_groups_pruned(), Some(3)); | ||
| assert_eq!(output.result_rows, 1, "{}", output.description()); | ||
| test_prune( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| test_prune( | |
| // result of sql "SELECT * FROM t where abs(i) = 1 and i = 1" | |
| // only use "i = 1" to prune | |
| test_prune( |
|
Benchmark runs are scheduled for baseline = 3d1de15 and contender = 0fa6a93. 0fa6a93 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
follow up #2977
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?