Skip to content

Conversation

@liukun4515
Copy link
Contributor

Which issue does this PR close?

follow up #2977

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@liukun4515 liukun4515 marked this pull request as ready for review July 30, 2022 03:13
@github-actions github-actions bot added the core Core DataFusion crate label Jul 30, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2986 (dc12063) into master (3d1de15) will decrease coverage by 0.00%.
The diff coverage is 98.92%.

@@            Coverage Diff             @@
##           master    #2986      +/-   ##
==========================================
- Coverage   85.78%   85.77%   -0.01%     
==========================================
  Files         281      281              
  Lines       51580    51526      -54     
==========================================
- Hits        44246    44197      -49     
+ Misses       7334     7329       -5     
Impacted Files Coverage Δ
datafusion/core/tests/parquet_pruning.rs 99.43% <98.92%> (+1.14%) ⬆️
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.77% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @liukun4515 this looks great

.query_with_expr(col("date64").lt(lit(date)))
// .query(
// "SELECT * FROM t where date64 < caste('2020-01-02' as date)",
// "SELECT * FROM t where date64 < cast('2020-01-02' as date)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

assert_eq!(output.predicate_evaluation_errors(), Some(0));
assert_eq!(output.row_groups_pruned(), Some(3));
assert_eq!(output.result_rows, 1, "{}", output.description());
test_prune(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test_prune(
// result of sql "SELECT * FROM t where abs(i) = 1 and i = 1"
// only use "i = 1" to prune
test_prune(

@alamb alamb merged commit 0fa6a93 into apache:master Jul 30, 2022
@ursabot
Copy link

ursabot commented Jul 30, 2022

Benchmark runs are scheduled for baseline = 3d1de15 and contender = 0fa6a93. 0fa6a93 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@liukun4515 liukun4515 deleted the collation_prune_parquet_file_test branch July 31, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants