Skip to content

feat: Enable typed strings expressions for VALUES clause #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2022
Merged

feat: Enable typed strings expressions for VALUES clause #3018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c46d61d
feat: Add support for typed strings to VALUES clause
stuartcarnie Aug 3, 2022
06ee0a5
chore: Tidy up 🧹
stuartcarnie Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions datafusion/sql/src/planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,6 +1613,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
&schema,
&mut HashMap::new(),
),
SQLExpr::TypedString { data_type, value } => Ok(Expr::Cast {
expr: Box::new(lit(value)),
data_type: convert_data_type(&data_type)?,
}),
other => Err(DataFusionError::NotImplemented(format!(
"Unsupported value {:?} in a values list expression",
other
Expand Down Expand Up @@ -1809,11 +1813,11 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
}),

SQLExpr::TypedString {
ref data_type,
ref value,
data_type,
value,
} => Ok(Expr::Cast {
expr: Box::new(lit(&**value)),
data_type: convert_data_type(data_type)?,
expr: Box::new(lit(value)),
data_type: convert_data_type(&data_type)?,
}),

SQLExpr::IsNull(expr) => Ok(Expr::IsNull(Box::new(
Expand Down Expand Up @@ -3247,6 +3251,17 @@ mod tests {
);
}

#[test]
fn select_from_typed_string_values() {
quick_test(
"SELECT col1, col2 FROM (VALUES (TIMESTAMP '2021-06-10 17:01:00Z', DATE '2004-04-09')) as t (col1, col2)",
"Projection: #t.col1, #t.col2\
\n Projection: #t.column1 AS col1, #t.column2 AS col2, alias=t\
\n Projection: #column1, #column2, alias=t\
\n Values: (CAST(Utf8(\"2021-06-10 17:01:00Z\") AS Timestamp(Nanosecond, None)), CAST(Utf8(\"2004-04-09\") AS Date32))",
);
}

#[test]
fn select_simple_aggregate_repeated_aggregate_with_repeated_aliases() {
let sql = "SELECT MIN(age) AS a, MIN(age) AS a FROM person";
Expand Down